From nobody Wed Aug 30 19:53:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RbZjJ3MgRz4sR51; Wed, 30 Aug 2023 19:53:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RbZjJ2rP2z4KRx; Wed, 30 Aug 2023 19:53:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693425204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xzTw7cXO1D7CZGH72GjHy1bdmyJPfrCJ27BXoEWD/ds=; b=gqNoeiS/DsK0S9ya4bsZsbwlz0l7G+34jSGXfEbzf7C1H8+F4yneq8uSN6GgIECWIezbqi 0PwN5pFTBSljgo5qD9Wj1wGVuvGKgvmtAuIViMPE3oslN8OP/d2fSJ7jXMcXZpageDHtCX HOzEYJjrHmXXXtdk6CGrEKhLjMHh8KTQBKcOayO9EIhxdVHW2g9BTCh3jf3e4VdZXWSJ4O hBeF2iAdX9Ohsj3P6zs4yE/3xzcy0WIrTvFO/oULfRZ9SO4LvXuHoMDWniwXgT7SumptYQ WJGYr1q6/uUXOZvfS1xEE1+s0L6OQ9FnDMwFfy91HVqmMg6Hoa8hc3/zOBxNNw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693425204; a=rsa-sha256; cv=none; b=ypLlXVApc3j1KoBnC6b6h40EPFXeAW0GxgvCI8l+RrXHj5u02w+6uFZWT65bM2yZwz8ZV6 y9sxBJP/wR7P6IkRaPG4KJpodOukEscwU0NlDjk4hutnp6XS+uoCRbAqc10C/K7C6cSRfO 1jSbhVN00zHIt5aXLjnvJkmusFfj0fEsDAL+n59V/9IXzL6MqAd569JAJRPnDTbkdoIz0y PaDT8YTEoj2AR2bXl15MRwuDmlXv+Rez0HOXW824KY8x6MNsNa8eLUT1vd7d7qWEWTDYuK fMqLCuvU1zcsXGOTQnRxX+LFXdZnCr5FPECZ1Y5oapmvnDFbWx3AWZ+fXEsNTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693425204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xzTw7cXO1D7CZGH72GjHy1bdmyJPfrCJ27BXoEWD/ds=; b=vhBZ0qatccK4Q/wPzUn/JKD/HL4XaKmGTTJ7SRWyOu6kJld3NRP2bmhC0R3WqKh4KuHDl8 qglzXDbLnFwc7tXrkyCRi5SGjBtathXTG0MdujIcik0TQofAvugIyeG61++jOSP4v8LkjT g2dwERXdbAn2TMwGq9Os0zYR6d31JtAEjnGeuU9APx9Q8qXh3d1DB9gHzkB/Z41mIOVAu5 83Abh0Pg8FuLddlsr65uzjcdldI/Mu6fYeFKVObjqJYVKwDZ+qEA1xqu7SYmirv/R8G2h1 3+AueEkkrfuId9v7fYlX5kfp1XLDfg3PrZ2afYUSi5PyyrDKshlcdNDov+XnoQ== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RbZjJ1GMBz8Pg; Wed, 30 Aug 2023 19:53:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 7849E140A1; Wed, 30 Aug 2023 21:53:21 +0200 (CEST) From: Kristof Provost To: Kevin Bowling Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, mmendoza@netgate.com Subject: Re: git: b6b75424c57d - main - vmxnet3: Don't restart on VLAN changes Date: Wed, 30 Aug 2023 21:53:20 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: <34CADCBB-B5E2-4E41-816E-4FAD36C474C3@FreeBSD.org> In-Reply-To: <202308242051.37OKpwUA039462@gitrepo.freebsd.org> References: <202308242051.37OKpwUA039462@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_AA43EB77-0E62-41E5-ACA6-C39CD04C4BF5_=" --=_MailMate_AA43EB77-0E62-41E5-ACA6-C39CD04C4BF5_= Content-Type: text/plain; format=flowed Content-Transfer-Encoding: quoted-printable On 24 Aug 2023, at 22:51, Kevin Bowling wrote: > The branch main has been updated by kbowling: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3Db6b75424c57d6da49967fef39f690= 80ce6939207 > > commit b6b75424c57d6da49967fef39f69080ce6939207 > Author: Kevin Bowling > AuthorDate: 2023-08-24 20:25:21 +0000 > Commit: Kevin Bowling > CommitDate: 2023-08-24 20:46:56 +0000 > > vmxnet3: Don't restart on VLAN changes > > In rS360398, a new iflib device method was added with default of = > opt out > for VLAN events needing an interface reset. > > This re-init is unintentional for vmxnet3(4). > It looks like we do need to re-init vmx interfaces when vlans are set. = Marcos has an ESXi 7.0.3 setup that breaks with this patch series. This fixes it: diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c = b/sys/dev/vmware/vmxnet3/if_vmx.c index 2c3530a217f..fdcad0dd4bb 100644 --- a/sys/dev/vmware/vmxnet3/if_vmx.c +++ b/sys/dev/vmware/vmxnet3/if_vmx.c @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, = enum iflib_restart_event event) { switch (event) { case IFLIB_RESTART_VLAN_CONFIG: + return (true); default: return (false); } Best regards, Kristof --=_MailMate_AA43EB77-0E62-41E5-ACA6-C39CD04C4BF5_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

On 24 Aug 2023, at 22:51, Kevin Bowling wrote:

The branch main has been updated by= kbowling:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3Db6b75424c57d6da49967fef39f69080ce6939207

commit b6b75424c57d6da49967fef39f69080ce6939207
Author: Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2023-08-24 20:25:21 +0000
Commit: Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2023-08-24 20:46:56 +0000

vmxnet3: Don't restart on VLAN changes

In rS360398, a new iflib device method was added with= default of opt out
for VLAN events needing an interface reset.

This re-init is unintentional for vmxnet3(4).


It looks like we do need to re-init vmx interfaces when v= lans are set. Marcos has an ESXi 7.0.3 setup that breaks with this patch = series.
This fixes it:

di=
ff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vm=
x.c
index 2c3530a217f..fdcad0dd4bb 100644
--- a/sys/dev/vmware/vmxnet3/if_vmx.c
+++ b/sys/dev/vmware/vmxnet3/if_vmx.c
@@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enu=
m iflib_restart_event event)
 {
        switch (event) {
        case IFLIB_RESTART_VLAN_CONFIG:
+               return (true);
        default:
                return (false);
        }

Best regards,
Kristof

--=_MailMate_AA43EB77-0E62-41E5-ACA6-C39CD04C4BF5_=--