From owner-svn-src-head@freebsd.org Thu Jun 1 14:18:06 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EACDDAFDF4F for ; Thu, 1 Jun 2017 14:18:06 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm27.bullet.mail.ne1.yahoo.com (nm27.bullet.mail.ne1.yahoo.com [98.138.90.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B255C7B87F for ; Thu, 1 Jun 2017 14:18:06 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1496326679; bh=/sqy9LDySgwv9FxxYPzWRVGeg97UIAl1s6zkLPFHT9U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=Reu86pmyqK1bbnzRsyerDo5ENOCJm0EI4j543SrgcbX2jq17Fq7B0N4dvCten+YFepJDViv9WDG2wTWR43XCX3u8XHZlUhFfgaDdneoU36/LjQrW2gFN5O+ZINGfLpFYPEPI8o5t6DXOlGg6eS39EE/gqNSTlC7aVS6NYyZj2wekqEbOyQ8K5RYr898GMi9tdtp3PsTifb1dRBU6mIW0G2IFagd1ZMbR4w6b7I/cD/llqCZl2k9mN+i4wAK3U22P0rKK7YVAVQ0Nue33IKpo6Cxnp5cqnK1XCp31J5zYyYeC2+5cX/zb/V1N9qh3AZSy2MVLpcNZ3itoiCJLDTah6w== Received: from [98.138.100.114] by nm27.bullet.mail.ne1.yahoo.com with NNFMP; 01 Jun 2017 14:17:59 -0000 Received: from [98.138.226.31] by tm105.bullet.mail.ne1.yahoo.com with NNFMP; 01 Jun 2017 14:17:59 -0000 Received: from [127.0.0.1] by smtp202.mail.ne1.yahoo.com with NNFMP; 01 Jun 2017 14:17:59 -0000 X-Yahoo-Newman-Id: 695425.44477.bm@smtp202.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: h8r0nbkVM1kSgqtlhIFa8wt6OukTaqquH3pIoVPQbv1T4fb BAN6k.jvmDlpkXh4z5G83562HU6lw2XrGwHxXa_QYk5PqBNPTuuQJuPdmkRo h68KIBzdlB1vFaYGNpRD0FyCvOFJdpdDk5DMvtXqgF.EJ.StzXAIDm5NdDb7 3cCS3XRyVkrkRV1IrKtJmizA2WXh.H9AVTWeSgLE9BqgmHjgKD.pgy8GgzBM U6x_KegG9zzL84yAoPpOuPK5TEFfL7mnFiSXHm9Q220_Y9LvoEkbQbHQ9LeZ BN6cvI_lgWcKF_Y2vZseulEGYcI92khkZd27uULvWNCRxgeB_FBkrRxIeQmd v2_huLs.a7Qxpnwq.GglJthDPdRImIRt9LeFH_161rQX0rMCPk_eboTU6NjR xmS08EZCOANo9tzLKCRIQOwCdzu3tgVy7as_H8uPlI2NowiLU4bGwNPsZdVc mLeuoh.pP2dO3cxupAvQKri7gZ3Pz0OgxS6ztBiezYEQe8ArvnAq3N6mHq2V yhn7jcTW73KPiERwP1xpaQJZgFmpMCZQSbvrCXAnU8E38Sqg- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests To: "Ngie Cooper (yaneurabeya)" , Brooks Davis Cc: Ngie Cooper , Marcel Moolenaar , "Simon J. Gerraty" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> From: Pedro Giffuni Organization: FreeBSD Message-ID: <7d59fb7c-7ac6-c545-103d-6185a2ee5c93@FreeBSD.org> Date: Thu, 1 Jun 2017 09:17:57 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 14:18:07 -0000 On 06/01/17 01:06, Ngie Cooper (yaneurabeya) wrote: >> On May 31, 2017, at 10:03 PM, Brooks Davis wrote: >> >> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: >>> Author: ngie >>> Date: Wed May 31 08:01:12 2017 >>> New Revision: 319295 >>> URL: https://svnweb.freebsd.org/changeset/base/319295 >>> >>> Log: >>> Update the usr.bin/mkimg golden test output files after ^/head@r319125 >>> >>> ^/head@r319125 changed the location of the backup pmbr, requiring the >>> output files to be regenerated, since they're binary disk dumps. >>> >>> The output files were regenerated with "make rebase"--fixed in >>> ^/head@r319294. >> These should not be stored uuencoded. It serves no purpose other >> than bloating the repo and causing spammy commit mails like this one >> where we got a huge tail of garbage output. > Hi Brooks, > I’m not entirely sure why the files were uuencoded to be honest. I think that’s a good question for Marcel and some of the folks at Juniper, since they wrote the tool/tests. for the record, it used to be a common practice. I think it's legacy from the CVS days. Pedro.