From owner-svn-src-all@FreeBSD.ORG  Thu Jul 29 16:40:45 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 875911065674;
	Thu, 29 Jul 2010 16:40:45 +0000 (UTC)
	(envelope-from jilles@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 769C48FC0A;
	Thu, 29 Jul 2010 16:40:45 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o6TGej90095737;
	Thu, 29 Jul 2010 16:40:45 GMT (envelope-from jilles@svn.freebsd.org)
Received: (from jilles@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o6TGejWI095735;
	Thu, 29 Jul 2010 16:40:45 GMT (envelope-from jilles@svn.freebsd.org)
Message-Id: <201007291640.o6TGejWI095735@svn.freebsd.org>
From: Jilles Tjoelker <jilles@FreeBSD.org>
Date: Thu, 29 Jul 2010 16:40:45 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r210613 - head/bin/kill
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2010 16:40:45 -0000

Author: jilles
Date: Thu Jul 29 16:40:45 2010
New Revision: 210613
URL: http://svn.freebsd.org/changeset/base/210613

Log:
  kill: Stop processing if a syntactically invalid pid is encountered.
  
  So a command like
    kill _HUP 1
  now fails without sending SIGTERM to init.
  
  The behaviour when kill(2) fails remains unchanged: processing continues.
  This matches other implementations and POSIX and is useful for killing
  multiple processes at once when some of them may already be gone.
  
  PR:		bin/40282

Modified:
  head/bin/kill/kill.c

Modified: head/bin/kill/kill.c
==============================================================================
--- head/bin/kill/kill.c	Thu Jul 29 16:30:27 2010	(r210612)
+++ head/bin/kill/kill.c	Thu Jul 29 16:40:45 2010	(r210613)
@@ -123,10 +123,9 @@ main(int argc, char *argv[])
 
 	for (errors = 0; argc; argc--, argv++) {
 		pid = strtol(*argv, &ep, 10);
-		if (!**argv || *ep) {
-			warnx("illegal process id: %s", *argv);
-			errors = 1;
-		} else if (kill(pid, numsig) == -1) {
+		if (!**argv || *ep)
+			errx(1, "illegal process id: %s", *argv);
+		else if (kill(pid, numsig) == -1) {
 			warn("%s", *argv);
 			errors = 1;
 		}