From owner-svn-ports-head@FreeBSD.ORG  Mon Dec  2 10:15:46 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CC4789CF;
 Mon,  2 Dec 2013 10:15:46 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A11EB15E8;
 Mon,  2 Dec 2013 10:15:44 +0000 (UTC)
Received: from [10.31.10.22] (unknown [213.225.137.129])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 7C7C143B8C;
 Mon,  2 Dec 2013 04:15:27 -0600 (CST)
Message-ID: <529C5DB1.6040800@marino.st>
Date: Mon, 02 Dec 2013 11:15:13 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: mike <mike@reifenberger.com>
Subject: Re: svn commit: r334598 - head/cad/kicad-devel
References: <201311221507.rAMF7cFW029817@svn.freebsd.org>
 <20131122155340.GA57808@FreeBSD.org>
 <alpine.WNT.2.00.1312021004480.3396@ux32.win.rm-i.net>
In-Reply-To: <alpine.WNT.2.00.1312021004480.3396@ux32.win.rm-i.net>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Dec 2013 10:15:46 -0000

On 12/2/2013 10:12, mike wrote:
> On Fri, 22 Nov 2013, Alexey Dokuchaev wrote:
> ...
>>> Log:
>>>   Use gcc for now.
>>
>> That's a notoriously bad commit message.  Thanks for being C.O.
>> explaining
>> the diff, but commit logs are supposed to tell us something about
>> *why* the
>> particular change was made.
>>
> 
> Sorry for not replying sooner.
> 
> I assumed that its obvious that a port gets only hardcoded to gcc in the
> case of a build error with clang.
> 
> So the commit line should have been:
> 
> Use gcc for now because of an build error with clang.


That's hardly better.
Why not include the actual error in the commit message?
That is done often to justify marking it as broken, it could also be
done to explain the workaround.

John

P.S.  To be fair, many folk here offer notoriously bad commit messages,
frequently.  I'm not sure why, maybe they just don't recognize it.