From owner-cvs-ports@FreeBSD.ORG  Mon Mar 29 11:34:09 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B50F6106566C;
	Mon, 29 Mar 2010 11:34:09 +0000 (UTC)
	(envelope-from kamikaze@bsdforen.de)
Received: from mail.bsdforen.de (bsdforen.de [212.204.60.79])
	by mx1.freebsd.org (Postfix) with ESMTP id 6DA0C8FC08;
	Mon, 29 Mar 2010 11:34:09 +0000 (UTC)
Received: from mobileKamikaze.norad (unknown [88.130.192.75])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.bsdforen.de (Postfix) with ESMTP id DB4448A1983;
	Mon, 29 Mar 2010 13:34:07 +0200 (CEST)
Message-ID: <4BB0902E.6070001@bsdforen.de>
Date: Mon, 29 Mar 2010 13:34:06 +0200
From: Dominic Fandrey <kamikaze@bsdforen.de>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-GB;
	rv:1.9.1.8) Gecko/20100329 Thunderbird/3.0.3
MIME-Version: 1.0
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
References: <201003290931.o2T9VrXu030819@repoman.freebsd.org>	<4BB07D0F.4090604@bsdforen.de>
	<20100329134959.18bf2919@it.buh.tecnik93.com>
In-Reply-To: <20100329134959.18bf2919@it.buh.tecnik93.com>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Dirk Meyer <dinoex@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/graphics/imlib2 Makefile
 ports/graphics/imlib2/files patch-loader_png.c
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2010 11:34:09 -0000

On 29/03/2010 12:49, Ion-Mihai Tetcu wrote:
> On Mon, 29 Mar 2010 12:12:31 +0200
> Dominic Fandrey <kamikaze@bsdforen.de> wrote:
> 
>> On 29/03/2010 11:31, Dirk Meyer wrote:
>>> dinoex      2010-03-29 09:31:53 UTC
>>>
>>>   FreeBSD ports repository
>>>
>>>   Modified files:
>>>     graphics/imlib2      Makefile 
>>>     graphics/imlib2/files patch-loader_png.c 
>>>   Log:
>>>   - fix code for png-1.4.1
>>>   
>>>   Revision  Changes    Path
>>>   1.136     +1 -1      ports/graphics/imlib2/Makefile
>>>   1.3       +1 -1      ports/graphics/imlib2/files/patch-loader_png.c
>>
>> Why did you rebreak imlib2?
>>
> 
> Trouble is this is the correct code, according to png developers:
> 
> libpng-1.4.1/CHANGES:  Changed png_check_sig() to !png_sig_cmp() in contrib programs.

I tested it and imlib2 does not work.

According to the documentation (http://www.libpng.org/pub/png/libpng-manual.txt):
	png_sig_cmp() ... will return 0 (false) if the bytes match the
	corresponding bytes of the PNG signature

I.e. it should be "png_sig_cmp(...) != 0" or "!png_sig_cmp(..)", just
the oposite of what is done, now.


-- 
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?