From owner-freebsd-net  Tue Jul 11 16: 0: 8 2000
Delivered-To: freebsd-net@freebsd.org
Received: from mail.interware.hu (mail.interware.hu [195.70.32.130])
	by hub.freebsd.org (Postfix) with ESMTP
	id 92E6C37B86C; Tue, 11 Jul 2000 15:59:58 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from harare-34.budapest.interware.hu ([195.70.50.34] helo=jules.elischer.org)
	by mail.interware.hu with smtp (Exim 3.12 #1 (Debian))
	id 13C90M-0004Kv-00; Wed, 12 Jul 2000 00:59:54 +0200
Message-ID: <396BA6D8.15FB7483@elischer.org>
Date: Tue, 11 Jul 2000 15:59:36 -0700
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 3.04Gold (X11; I; FreeBSD 5.0-CURRENT i386)
MIME-Version: 1.0
To: Archie Cobbs <archie@whistle.com>
Cc: freebsd-net@freebsd.org, csg@waterspout.com, ache@freebsd.org,
	wpaul@freebsd.org, imp@village.org
Subject: Re: ether_ifattach()/ether_ifdetach() patch
References: <200007112233.PAA39900@bubba.whistle.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Archie Cobbs wrote:
> 
> To any interested parties, here is a patch to review.
> 
> This changes all ethernet drivers to only call ether_ifattach()
> and ether_ifdetach(), consolidating some common actions, namely,
> calls to if_attach(), bpfattach(), ng_ether_attach(), if_detach(),
> bpfdetach(), and ng_ether_detach().
> 
> This also fixes the problem where detaching an ethernet interface
> previously used for ng_ether(4) would panic (which resulted from
> fixing the build to not require 'device ether' (which resulted
> from making ng_ether(4) a loadable KLD)).
> 
>   ftp://ftp.whistle.com/pub/archie/misc/ETHERATTACH.patch.1

The constant 1 (2nd argument to ether_attach) should be
defined as something meaningful in the ethernet include file.
e.g. USE_BPF vs NO_BPF
Ether definitions should be removed from if_var.h
and also put in an ether specific include file,
but that would  be a different patch.

> 
> Thanks,
> -Archie
> 
> ___________________________________________________________________________
> Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000
     ;_.---._/  presently in:  Budapest
            v


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message