From owner-freebsd-current@FreeBSD.ORG Wed Apr 30 09:31:31 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E05437B401 for ; Wed, 30 Apr 2003 09:31:31 -0700 (PDT) Received: from revolution.de (dialin-145-254-233-046.arcor-ip.net [145.254.233.46]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF28343F75 for ; Wed, 30 Apr 2003 09:31:27 -0700 (PDT) (envelope-from georgfunk@web.de) Received: from revolution (localhost [127.0.0.1]) by revolution.de (8.12.6/8.12.6) with ESMTP id h3UGSfg7000617; Wed, 30 Apr 2003 18:28:44 +0200 (CEST) (envelope-from georgfunk@web.de) Content-Type: text/plain; charset="iso-8859-1" From: Georg Funk To: sigsegv@leakingmemory.org Date: Wed, 30 Apr 2003 18:28:37 +0200 User-Agent: KMail/1.4.3 References: <200304301455.23334.georgfunk@web.de> <200304301633.21927.sigsegv@leakingmemory.org> In-Reply-To: <200304301633.21927.sigsegv@leakingmemory.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200304301828.37987.georgfunk@web.de> cc: freebsd-current@freebsd.org Subject: Re: lock order reversal X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2003 16:31:31 -0000 hm, the patch doesn't seem to work: -------------------------------------------------- #patch < pcm.diff Hmm... Looks like a normal diff to me... The text leading up to this was: -------------------------- |cvs diff: Diffing sys/dev/sound/pcm |Index: sys/dev/sound/pcm/dsp.c |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |RCS file:=20 /old/pub/FreeBSD/development/FreeBSD-CVS/src/sys/dev/sound/pcm/dsp.c,v |retrieving revision 1.62 |diff -r1.62 dsp.c -------------------------- Patching file dsp.c using Plan A... Hunk #1 failed at 265. Hunk #2 failed at 270. Hunk #3 failed at 287. Hunk #4 succeeded at 304. 3 out of 4 hunks failed--saving rejects to dsp.c.rej done On Wednesday 30 April 2003 16:33, you wrote: > On Wednesday 30 April 2003 14:55, Georg Funk wrote: > > Hi! > > I'm running the FreeBSD 5.0-RELEASE. When I boot up, this appears: > > > > 1st 0xc12a7230 process lock (process lock) @ > > ../../../kern/kern_descrip.c:2112 lock order reversal > > I haven't noticed any disfunctions, but what does this mean? > > > > I get a similar error when I use my soundcard: > > > > lock order reversal > > 1st 0xc120a680 pcm0 (sound softc) @ ../../../dev/sound/isa/mss.c:177 > > 2nd 0xc120a740 pcm0:play:0 (pcm channel) @ > > ../../../dev/sound/pcm/channel.c:441 > > > > I have to restart the KDE artsd before the soundcard works correct. > > Please give me advice how to solve this. > > > > Thanks in advance, Georg Funk > > I have also seen that problem, and this patch seems to work here.. > It is probably not very optimized, but the lock order reversal didn't s= how > up again... > > cvs diff: Diffing sys/dev/sound/pcm > Index: sys/dev/sound/pcm/dsp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: > /old/pub/FreeBSD/development/FreeBSD-CVS/src/sys/dev/sound/pcm/dsp.c,v > retrieving revision 1.62 > diff -r1.62 dsp.c > 265,266c265 > < pcm_unlock(d); > < /* finished with snddev, new channels still locked */ > --- > > > /* keep the snddev lock to avoid a lock order reversal, new > > channels still locked */ > > 271d269 > < pcm_lock(d); > 289d286 > < pcm_lock(d); > 306a304 > > > pcm_unlock(d); > > Regards, > Jan-Espen Pettersen ------------------------------------------------