From owner-cvs-all@FreeBSD.ORG Tue Nov 28 23:12:50 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DEC7916A407; Tue, 28 Nov 2006 23:12:50 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from ns2.pil.dk (ns2.pil.dk [195.41.47.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41C7C43CAE; Tue, 28 Nov 2006 23:12:44 +0000 (GMT) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by ns2.pil.dk (Postfix) with ESMTP id B1D637BA1DE; Wed, 29 Nov 2006 00:12:48 +0100 (CET) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id 07AE3B9D7; Wed, 29 Nov 2006 00:12:47 +0100 (CET) Date: Wed, 29 Nov 2006 00:12:47 +0100 From: Henrik Brix Andersen To: Ruslan Ermilov Message-ID: <20061128231247.GB73497@tirith.brixandersen.dk> Mail-Followup-To: Ruslan Ermilov , Florent Thoumie , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200611282113.kASLD8vu090754@repoman.freebsd.org> <20061128220111.GA71168@tirith.brixandersen.dk> <20061128220529.GA38107@rambler-co.ru> <20061128222641.GA73497@tirith.brixandersen.dk> <20061128224915.GA38469@rambler-co.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq" Content-Disposition: inline In-Reply-To: <20061128224915.GA38469@rambler-co.ru> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.13 (2006-08-11) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Florent Thoumie Subject: Re: cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2006 23:12:51 -0000 --ftEhullJWpWg/VHq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2006 at 01:49:15AM +0300, Ruslan Ermilov wrote: > On Tue, Nov 28, 2006 at 11:26:41PM +0100, Henrik Brix Andersen wrote: > > On Wed, Nov 29, 2006 at 01:05:29AM +0300, Ruslan Ermilov wrote: > > > Why can't you just check for the defined constant? > >=20 > > To clarify: it is a run-time issue, not a compile-time issue. The > > application will compile fine regardless of the above patch, but > > without the above patch (and with ukbd/uhid loaded) the application > > will fail to attach to the device. > >=20 > You want to build a port only when you know that the kernel has > this fix? That is my intention, yes. Otherwise end-users will likely be confused as to why the application fails to detect their device. Regards, Brix --=20 Henrik Brix Andersen --ftEhullJWpWg/VHq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: GnuPG signed iD8DBQFFbMJvv+Q4flTiePgRApBoAKCD7fjKsVFHaGvwLJX92AruNvyHHACfUChw 7i1Zk4K7Cp4vJ2nOstJP5CU= =86uj -----END PGP SIGNATURE----- --ftEhullJWpWg/VHq--