From owner-freebsd-hackers@FreeBSD.ORG  Mon May 17 12:49:17 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3544816A4CE
	for <freebsd-hackers@freebsd.org>;
	Mon, 17 May 2004 12:49:16 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 44BAD43D48
	for <freebsd-hackers@freebsd.org>;
	Mon, 17 May 2004 12:49:16 -0700 (PDT)	(envelope-from cagney@gnu.org)
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i4HJnERm011646;
	Mon, 17 May 2004 15:49:14 -0400
Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com
	[172.16.14.151])i4HJn6027339;	Mon, 17 May 2004 15:49:10 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 0D1292B9D; Mon, 17 May 2004 15:49:00 -0400 (EDT)
Message-ID: <40A9172B.9000300@gnu.org>
Date: Mon, 17 May 2004 15:48:59 -0400
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB;
	rv:1.4.1) Gecko/20040217
X-Accept-Language: en, en-us
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
References: <200405171132.i4HBW0h5012696@elgar.kettenis.dyndns.org>
In-Reply-To: <200405171132.i4HBW0h5012696@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Tue, 18 May 2004 05:03:33 -0700
cc: freebsd-hackers@freebsd.org
cc: tech-toolchain@netbsd.org
cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] *BSD kernel debugging
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2004 19:49:17 -0000

> +void
> +_initialize_bsd_kvm (void)
> +{
> +  bsd_kvm_ops.to_shortname = "kvm";
> +  bsd_kvm_ops.to_longname = "Kernel memory interface";
> +  bsd_kvm_ops.to_doc = "XXX";
> +  bsd_kvm_ops.to_open = bsd_kvm_open;
> +  bsd_kvm_ops.to_close = bsd_kvm_close;
> +  bsd_kvm_ops.to_fetch_registers = bsd_kvm_fetch_registers;
> +  bsd_kvm_ops.to_xfer_memory = bsd_kvm_xfer_memory;
> +  bsd_kvm_ops.to_stratum = process_stratum;
> +  bsd_kvm_ops.to_has_memory = 1;
> +  bsd_kvm_ops.to_has_stack = 1;
> +  bsd_kvm_ops.to_has_registers = 1;
> +  bsd_kvm_ops.to_magic = OPS_MAGIC;
> +
> +  add_target (&bsd_kvm_ops);
> +}

Can the deck chairs be re-arange a little here?  Instead of having:
	bsd_kvm_supply_pcb
picked up by accident, add an _initialize to the *-nat.c files where 
they can do something more explicit vis:

	_initialize_foobsd_nat ()
	{
	  add_bsd_kvm_target (foobsd_kvm_supply_pcb);
	}

Andrew