From owner-svn-src-head@freebsd.org  Wed Aug  5 06:25:41 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46A1A9B4C77;
 Wed,  5 Aug 2015 06:25:41 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au
 [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id EE718762;
 Wed,  5 Aug 2015 06:25:40 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au
 (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197])
 by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 68F671A2209;
 Wed,  5 Aug 2015 16:25:34 +1000 (AEST)
Date: Wed, 5 Aug 2015 16:25:34 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Jung-uk Kim <jkim@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r286293 - head/sys/x86/include
In-Reply-To: <201508041859.t74IxtCh047275@repo.freebsd.org>
Message-ID: <20150805162146.H1434@besplex.bde.org>
References: <201508041859.t74IxtCh047275@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=XMDNMlVE c=1 sm=1 tr=0
 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8
 a=kj9zAlcOel0A:10 a=y8ldLoeJNce22yX4hrYA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2015 06:25:41 -0000

On Tue, 4 Aug 2015, Jung-uk Kim wrote:

> Log:
>  Fix style(9) bugs.

Thanks.

> Modified:
>  head/sys/x86/include/_types.h
>
> Modified: head/sys/x86/include/_types.h
> ==============================================================================
> --- head/sys/x86/include/_types.h	Tue Aug  4 17:47:11 2015	(r286292)
> +++ head/sys/x86/include/_types.h	Tue Aug  4 18:59:54 2015	(r286293)
> @@ -154,12 +154,11 @@ typedef	int		___wchar_t;
> typedef	__builtin_va_list	__va_list;	/* internally known to gcc */
> #else
> #ifdef __LP64__
> -typedef	struct {
> -	unsigned int	__gpo;
> -	unsigned int	__fpo;
> -	void		*__oaa;
> -	void		*__rsa;
> -} __va_list;
> +struct __s_va_list {
> +	__uint32_t	pad1[2];	/* gp_offset, fp_offset */
> +	__uint64_t	pad2[2];	/* overflow_arg_area, reg_save_area */
> +};

Er, the struct members need at least 1 underscore, since pad* is in the
application namespace and this is a very public file.

> +typedef struct __s_va_list	__va_list;

I said to use #define, but now prefer this since it is better for debuggers
and all the nearby __va_list's are typedefs.

This typedef should be followed by a tab like all the nearby ones.

> #else
> typedef	char *			__va_list;
> #endif

Bruce