From owner-cvs-all@FreeBSD.ORG  Mon Aug 23 19:01:08 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C78416A4CF; Mon, 23 Aug 2004 19:01:08 +0000 (GMT)
Received: from itchy.rabson.org (mailgate.nlsystems.com [80.177.232.242])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 78D2243D55; Mon, 23 Aug 2004 19:01:07 +0000 (GMT)
	(envelope-from dfr@nlsystems.com)
Received: from ns0.nlsystems.com (ns0.nlsystems.com [80.177.232.243])
	by itchy.rabson.org (8.12.11/8.12.11) with ESMTP id i7NJ13mT053984;
	Mon, 23 Aug 2004 20:01:03 +0100 (BST)
	(envelope-from dfr@nlsystems.com)
From: Doug Rabson <dfr@nlsystems.com>
To: Marcel Moolenaar <marcel@xcllnt.net>
Date: Mon, 23 Aug 2004 20:01:22 +0100
User-Agent: KMail/1.6.2
References: <200408231530.i7NFU5bu082414@repoman.freebsd.org>
	<1093283234.16672.2.camel@builder02.qubesoft.com>
	<20040823181827.GA706@dhcp50.pn.xcllnt.net>
In-Reply-To: <20040823181827.GA706@dhcp50.pn.xcllnt.net>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200408232001.22449.dfr@nlsystems.com>
X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on itchy.rabson.org
X-Virus-Scanned: clamd / ClamAV version 0.75.1, clamav-milter version 0.75c
	on itchy.rabson.org
X-Virus-Status: Clean
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/gen tls.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Aug 2004 19:01:08 -0000

On Monday 23 August 2004 19:18, Marcel Moolenaar wrote:
> On Mon, Aug 23, 2004 at 06:47:15PM +0100, Doug Rabson wrote:
> > On Mon, 2004-08-23 at 16:30, Doug Rabson wrote:
> > > dfr         2004-08-23 15:30:05 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     lib/libc/gen         tls.c
> > >   Log:
> > >   Make sure we allocate at least enough space for the TCB for
> > > variant I TLS.
> >
> > This is the real fix for the static binaries segfaulting on alpha.
> > With this we could re-add the change to crt1.c which enables TLS
> > for static binaries. Given that we don't yet fully support TLS for
> > alpha in either rtld or libpthread, I don't propose to change
> > lib/csu/alpha/crt1.c again for 5.3.
>
> However, if we revert the backout of crt1.c, then we know that all
> shared executables will work the moment we fix rtld and libpthread.
> If we keep the call to _init_tls() removed from crt1.c then every
> binary linked on a 5.3 machine needs to be relinked the moment we
> do add proper TLS support. So, to minimize (future) burden I suggest
> we change crt1.c back for 5.3 as well. Otherwise this will just be
> another exception on Alpha...
>
> The above obviously conditional upon re@ approval.

Another thing which confuses me right now is that the same bug ought to 
have affected ia64 and powerpc since they both would like to use 
variant I style TLS. Odd.