From owner-freebsd-toolchain@freebsd.org Fri Nov 3 02:23:29 2017 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C34DE68A8C; Fri, 3 Nov 2017 02:23:29 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E17C4727EC; Fri, 3 Nov 2017 02:23:28 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id vA32NRsp088749 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 2 Nov 2017 19:23:27 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id vA32NRCr088748; Thu, 2 Nov 2017 19:23:27 -0700 (PDT) (envelope-from sgk) Date: Thu, 2 Nov 2017 19:23:27 -0700 From: Steve Kargl To: Bryan Drewery Cc: FreeBSD Toolchain , freebsd-hackers , FreeBSD Current Subject: Re: Head build unsafe for /etc today Message-ID: <20171103022327.GA88659@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:23:29 -0000 On Thu, Nov 02, 2017 at 07:08:50PM -0700, Bryan Drewery wrote: > > > > On Nov 2, 2017, at 18:49, Steve Kargl wrote: > > > >> On Thu, Nov 02, 2017 at 06:25:24PM -0700, Bryan Drewery wrote: > >> > >> On Nov 2, 2017, at 15:44, Mark Millard wrote: > >> > >>>> Author: bdrewery > >>>> Date: Thu Nov 2 22:23:00 2017 > >>>> New Revision: 325347 > >>>> URL: > >>>> https://svnweb.freebsd.org/changeset/base/325347 > >>>> > >>>> > >>>> Log: > >>>> Something is very wrong > >> > >> > >> Unfortunately I only test with META_MODE these days which implies -DNO_CLEAN. > > > > You're making changes to the build infrastructure and you're > > not properly testing it before committing? This is beyond > > pointyhat material. > > I ran 2 universes, dozens of buildworlds and buildkernels, dozens of installworld and installkernel, several xdev and native-xtools, several full DIRDEPS_BUILD builds and bootstraps, ran subdir builds, ran subdir cleans, tested several targets together, ran various special case tests for submakes, played around with a ton of MAKEOBJDIRPREFIX cases, handled and tested symlinked objdirs special, ran it through my work repro a few times, did special testing in rescue/, and had a volunteer test release. In the process I found a bmake bug, GPL_DTC build bug and several others I don’t recall from the bus. > > What I missed was the “clean” buildworld because I forgot it even exists. I’ve wanted to remove it for a year. I also forgot to test buildenv. > If you did all the above under META_MODE, then no you did not buildworld and buildkernel and all the other stuff you claim. If your first step isn't 'cd /usr/obj ; rm -rf *' or equivalent in whatever jail you use, then you're not properly testing your changes to the build infrastructure. As you have demonstrated, Makefile, Makefile.inc1, and the *.mk files are sufficiently complicated that proper testing should be done, and proper testing means one doesn't takes shortcuts. -- Steve