From owner-cvs-all@FreeBSD.ORG Fri Mar 11 02:41:26 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 2D893106567B; Fri, 11 Mar 2011 02:41:26 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from doug-optiplex.ka9q.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 19CA614E41C; Fri, 11 Mar 2011 02:41:23 +0000 (UTC) Message-ID: <4D798BD2.2030400@FreeBSD.org> Date: Thu, 10 Mar 2011 18:41:22 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110304 Thunderbird/3.1.9 MIME-Version: 1.0 To: Martin Wilke References: <201103091401.p29E1mtM086605@repoman.freebsd.org> In-Reply-To: <201103091401.p29E1mtM086605@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, John Hein , john.c.prather@gmail.com, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/davmail Makefile distinfo pkg-plist ports/mail/davmail/files davmail.in davmail.properties.sample davmail.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2011 02:41:26 -0000 Couple of comments on the rc.d script: 1. The %%PORTNAME%% obfuscation isn't worth the effort. It doesn't have any good benefits that make it worth causing the difficulty in reading the script in the tree. 2. If the script starts a persistent service (which it seems to) it needs "KEYWORD: SHUTDOWN" 3. procname probably wants to be command_interpreter, but that should be tested. hth, Doug On 03/09/2011 06:01, Martin Wilke wrote: > miwi 2011-03-09 14:01:48 UTC > > FreeBSD ports repository > > Modified files: > mail/davmail Makefile distinfo pkg-plist > mail/davmail/files davmail.sh.in > Added files: > mail/davmail/files davmail.in davmail.properties.sample > Log: > - Update to 3.9.0 > > PR: 154982 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=154982 > Submitted by: John Hein > Approved by: maintainer > > Revision Changes Path > 1.3 +19 -11 ports/mail/davmail/Makefile > 1.3 +2 -2 ports/mail/davmail/distinfo > 1.1 +43 -0 ports/mail/davmail/files/davmail.in (new) > 1.1 +34 -0 ports/mail/davmail/files/davmail.properties.sample (new) > 1.2 +3 -2 ports/mail/davmail/files/davmail.sh.in > 1.3 +3 -0 ports/mail/davmail/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/Makefile.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/distinfo.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.properties.sample > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.sh.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/