From owner-freebsd-wireless@FreeBSD.ORG Sat Aug 3 19:23:39 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 430EC98B; Sat, 3 Aug 2013 19:23:39 +0000 (UTC) (envelope-from cg@cgross.info) Received: from alpha.kreiz-it.fr (alpha.kreiz-it.fr [IPv6:2001:41d0:8:dda6::1]) by mx1.freebsd.org (Postfix) with ESMTP id 07D962B5A; Sat, 3 Aug 2013 19:23:38 +0000 (UTC) Received: from DirTech (lnr56-1-82-246-51-185.fbx.proxad.net [82.246.51.185]) by alpha.kreiz-it.fr (Postfix) with ESMTPSA id A077B5F7; Sat, 3 Aug 2013 21:23:36 +0200 (CEST) From: "Cedric GROSS" To: "'Adrian Chadd'" References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> <002d01ce8c46$a13b23d0$e3b16b70$@info> <002701ce8e03$c033f640$409be2c0$@info> <002401ce8f5f$fc5ad780$f5108680$@info> <001001ce903b$e77a5f70$b66f1e50$@info> In-Reply-To: Subject: RE: [IWN] Reviw split 2 Date: Sat, 3 Aug 2013 21:23:31 +0200 Message-ID: <001e01ce907e$f1daf220$d590d660$@info> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac6QdgjjWcDsF0dqT62EkSMM8lCKBAABvIjg Content-Language: fr Cc: freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Aug 2013 19:23:39 -0000 > De=A0: adrian.chadd@gmail.com [mailto:adrian.chadd@gmail.com] De la = part > de Adrian Chadd > Envoy=E9=A0: samedi 3 ao=FBt 2013 20:20 > =C0=A0: Cedric GROSS > Cc=A0: freebsd-wireless@freebsd.org > Objet=A0: Re: [IWN] Reviw split 2 >=20 > On 3 August 2013 04:23, Cedric GROSS wrote: >=20 > >> Can you please post an updated diff against what's in -HEAD now? > > > > As requested here is full patch. >=20 > Thanks! >=20 > > It should. 4965 part was not impacted. But Don't you said that full > > patch break your 5100 ? >=20 > Yup, it is breaking it very quickly. I'll try this patch against -HEAD > and see what happens. Ok. >=20 > But, there's ~ 4000 lines of patch to review. Some bits are easy to > merge, some bits aren't easy to merge. :) >=20 It's surely in parameters part that there's a fail. May be will end by = that. > Thanks! What would you like to merge next? Prepare for context switching (the sc->rxon modification), it's still modification without adding functionality.=20 And after that, adding context switching with PAN support, should not = break your NIC. Next, may be parameter by parameter, so we will see where is break. With bapt help, I'm also pointing a problem with AMRR. With time, rate = is still decreasing because of cumulative ackfailcnt transmit to ieee80211_ratectl_tx_complete. What kind of value does this function wait ? Absolute number or relative = to the previous call ? Also, why do you send it by ref in iwn_tx_done ? >=20 > -adrian Cedric