From owner-cvs-all@FreeBSD.ORG  Tue Apr 29 13:09:07 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4472737B401; Tue, 29 Apr 2003 13:09:07 -0700 (PDT)
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 66A6D43FBD; Tue, 29 Apr 2003 13:09:06 -0700 (PDT)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu
	[152.3.145.30])
	by duke.cs.duke.edu (8.12.9/8.12.9) with ESMTP id h3TK94MS008806
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Tue, 29 Apr 2003 16:09:05 -0400 (EDT)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.11.6/8.9.1) id h3TK8xq84392;
	Tue, 29 Apr 2003 16:08:59 -0400 (EDT)
	(envelope-from gallatin@cs.duke.edu)
From: Andrew Gallatin <gallatin@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16046.56283.631906.102138@grasshopper.cs.duke.edu>
Date: Tue, 29 Apr 2003 16:08:59 -0400 (EDT)
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030429.135157.94399579.imp@bsdimp.com>
References: <16046.51947.425815.273156@grasshopper.cs.duke.edu>
	<XFMail.20030429152414.jhb@FreeBSD.org>
	<20030429.135157.94399579.imp@bsdimp.com>
X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: jhb@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Apr 2003 20:09:07 -0000


M. Warner Losh writes:
 > 
 > Comments?

Mostly OK by me, except for the // style comments.

Also, I'm not sure that checking for mutex_owned in the ioctl function
is right.  Picture ifconfig'ing an interface down (or starting
tcpdump) while you're undergoing a DOS attach.  Can you check for
suspened instead?

I'd still like to wrangle a generic, safe way of detaching interfaces
out of John though ;)

Drew