Date: Thu, 15 Nov 2012 13:06:27 +0100 (CET) From: Emanuel Haupt <ehaupt@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/173649: Update ports-mgmt/portlint to warn about .DS_Store meta data files Message-ID: <201211151206.qAFC6Rg8095441@freefall.freebsd.org> Resent-Message-ID: <201211151210.qAFCA0Qm095485@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173649
>Category: ports
>Synopsis: Update ports-mgmt/portlint to warn about .DS_Store meta data files
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Thu Nov 15 12:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Emanuel Haupt
>Release: FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #4 r242881M: Sun Nov 11 05:30:05 UTC 2012 root@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64
>Description:
grep -r "\.DS_Store" /usr/ports shows that way to many ports carelessly install
.DS_Store meta data files. Provide a patch to warn about such files.
>How-To-Repeat:
>Fix:
--- portlint.patch begins here ---
Index: src/portlint.pl
===================================================================
--- src/portlint.pl (revision 307449)
+++ src/portlint.pl (working copy)
@@ -746,6 +746,10 @@
$_ =~ s/\s+$//;
$_ =~ s/\n$//;
+ if ($_ =~ /\.DS_Store/) {
+ &perror("WARN", $file, $., ".DS_Store meta data files must not be installed.");
+ }
+
if ($osname eq 'NetBSD' && $_ =~ /<\$ARCH>/) {
&perror("WARN", $file, $., "use of <\$ARCH> deprecated, ".
"use \${MACHINE_ARCH} instead.");
--- portlint.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211151206.qAFC6Rg8095441>