From owner-freebsd-gnome@FreeBSD.ORG Sun Nov 4 20:07:41 2007 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04D3116A418 for ; Sun, 4 Nov 2007 20:07:41 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id A9AFC13C494 for ; Sun, 4 Nov 2007 20:07:40 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.1/8.14.1) with ESMTP id lA4K9NnP008835; Sun, 4 Nov 2007 15:09:23 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Yuri Pankov In-Reply-To: <1194206264.1265.2.camel@darklight.org.ru> References: <200711031707.lA3H7KSI002054@bbeng-laptop.acs.internap.com> <1194206264.1265.2.camel@darklight.org.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-7JBnzK2AVEKz7Z1z4Ts6" Organization: MarcusCom, Inc. Date: Sun, 04 Nov 2007 15:07:36 -0500 Message-Id: <1194206856.3161.5.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on creme-brulee.marcuscom.com Cc: gnome@freebsd.org Subject: Re: [PATCH] databases/evolution-data-server: Fix segfault on new installs X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2007 20:07:41 -0000 --=-7JBnzK2AVEKz7Z1z4Ts6 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2007-11-04 at 22:57 +0300, Yuri Pankov wrote: > On Sat, 2007-11-03 at 13:07 -0400, Robert C. Noland III wrote: > > >Submitter-Id: current-users > > >Originator: Robert C. Noland III > > >Organization:=09 > > >Confidential: no=20 > > >Synopsis: [PATCH] databases/evolution-data-server: Fix segfault on new= installs > > >Severity: non-critical > > >Priority: low > > >Category: ports=20 > > >Class: change-request > > >Release: FreeBSD 8.0-CURRENT i386 > > >Environment: > > System: FreeBSD bbeng-laptop.acs.internap.com 8.0-CURRENT FreeBSD 8.0-C= URRENT #92: Mon Oct 15 12:26:58 EDT 2007 > > >Description: > > Evolution will segfault while trying to collect timezone data on a new = install. > > Off by one test in timezone parsing.=20 > >=20 > > Port maintainer (gnome@FreeBSD.org) is cc'd. > >=20 > > Generated with FreeBSD Port Tools 0.77 > > >How-To-Repeat: > > >Fix: > >=20 > > --- evolution-data-server-1.12.1_2.patch begins here --- > > Index: Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/ports/databases/evolution-data-server/Makefile,v > > retrieving revision 1.41 > > diff -u -r1.41 Makefile > > --- Makefile 24 Oct 2007 23:35:16 -0000 1.41 > > +++ Makefile 3 Nov 2007 17:04:29 -0000 > > @@ -8,7 +8,7 @@ > > =20 > > PORTNAME=3D evolution-data-server > > PORTVERSION=3D 1.12.1 > > -PORTREVISION=3D 1 > > +PORTREVISION=3D 2 > > CATEGORIES=3D databases gnome > > MASTER_SITES=3D ${MASTER_SITE_GNOME} > > MASTER_SITE_SUBDIR=3D sources/${PORTNAME}/${PORTVERSION:C/^([0-9]+\.[0= -9]+).*/\1/} > > Index: files/patch-calendar_libical_src_libical_icaltz-util.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/ports/databases/evolution-data-server/files/patch-= calendar_libical_src_libical_icaltz-util.c,v > > retrieving revision 1.1 > > diff -u -r1.1 patch-calendar_libical_src_libical_icaltz-util.c > > --- files/patch-calendar_libical_src_libical_icaltz-util.c 24 Oct 2007 = 23:35:17 -0000 1.1 > > +++ files/patch-calendar_libical_src_libical_icaltz-util.c 3 Nov 2007 1= 7:04:29 -0000 > > @@ -1,5 +1,5 @@ > > ---- calendar/libical/src/libical/icaltz-util.c.orig 2007-08-24 02:48:2= 8.000000000 -0400 > > -+++ calendar/libical/src/libical/icaltz-util.c 2007-08-27 16:23:59.000= 000000 -0400 > > +--- calendar/libical/src/libical/icaltz-util.c.orig 2007-10-12 02:31:1= 0.000000000 -0400 > > ++++ calendar/libical/src/libical/icaltz-util.c 2007-11-03 12:22:24.000= 000000 -0400 > > @@ -23,6 +23,15 @@ > > #include > > #if defined(sun) && defined(__SVR4) > > @@ -16,3 +16,12 @@ > > #else > > #include > > #include > > +@@ -148,7 +157,7 @@ > > + idx =3D trans_idx [i]; > > + types [idx].isdst ? (*dstidx =3D i) : (*stdidx =3D i); > > + =09 > > +- if (i >=3D num_trans)=20 > > ++ if (i >=3D num_trans - 1)=20 > > + i--; > > + else=20 > > + i++; > > --- evolution-data-server-1.12.1_2.patch ends here --- >=20 > It looks very similar to the crash I've been experiencing - > http://bugzilla.gnome.org/show_bug.cgi?id=3D492426 > If it's indeed the same problem, could you please submit a followup > there? Please test his patch, and see if it fixes the bug. If so, I will commit before the release. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-7JBnzK2AVEKz7Z1z4Ts6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHLiaHb2iPiv4Uz4cRAjz9AJ4ye/+uuQO6kFjsKy0CZv9ktj5nNACdFAWT bR1rE0B+oYb1ZYjZmx2Ka+s= =ulzw -----END PGP SIGNATURE----- --=-7JBnzK2AVEKz7Z1z4Ts6--