From owner-freebsd-pf@FreeBSD.ORG Mon Jan 28 20:20:03 2008 Return-Path: Delivered-To: freebsd-pf@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D88B16A418 for ; Mon, 28 Jan 2008 20:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EDCA313C459 for ; Mon, 28 Jan 2008 20:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0SKK2TC065128 for ; Mon, 28 Jan 2008 20:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0SKK2v9065127; Mon, 28 Jan 2008 20:20:02 GMT (envelope-from gnats) Date: Mon, 28 Jan 2008 20:20:02 GMT Message-Id: <200801282020.m0SKK2v9065127@freefall.freebsd.org> To: freebsd-pf@FreeBSD.org From: "=?ISO-8859-1?Q?Ermal_Lu=E7i?=" Cc: Subject: Re: kern/120057: [patch] Allow proper settings of ALTQ_HFSC. The check i wrong since even with the values forbidden from this check you get a concave curve. X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: =?ISO-8859-1?Q?Ermal_Lu=E7i?= List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 20:20:03 -0000 The following reply was made to PR kern/120057; it has been noted by GNATS. From: "=?ISO-8859-1?Q?Ermal_Lu=E7i?=" To: "Max Laier" Cc: bug-followup@freebsd.org, eri@freebsd.org Subject: Re: kern/120057: [patch] Allow proper settings of ALTQ_HFSC. The check i wrong since even with the values forbidden from this check you get a concave curve. Date: Mon, 28 Jan 2008 21:13:41 +0100 Also not that the link you gave me, has the note: In order to decouple delay and bandwidth allocation, HFSC is designed based on the service curve service model. In HFSC, only two-piece linear service curves are used for simplicity. A two-piece linear service curve is characterized by three parameters: * m1, the slope of the first segment * m2, the slope of the second segment * d, the x-projection of the intersection point of the two segments The following figure illustrates the two types of two-piece linear service curves used in HFSC. For a convex curve (when m1 is less than m2), m1 is always zero. But beware, that