From owner-svn-src-all@FreeBSD.ORG  Tue Apr 10 13:58:26 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 631CB106564A;
	Tue, 10 Apr 2012 13:58:26 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 35A6D8FC0A;
	Tue, 10 Apr 2012 13:58:26 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 98EDFB911;
	Tue, 10 Apr 2012 09:58:25 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Marius Strobl <marius@alchemy.franken.de>
Date: Tue, 10 Apr 2012 09:33:32 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <201204092241.q39MfJZn081610@svn.freebsd.org>
	<20120409230949.GB68111@alchemy.franken.de>
In-Reply-To: <20120409230949.GB68111@alchemy.franken.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201204100933.32374.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 10 Apr 2012 09:58:25 -0400 (EDT)
Cc: Attilio Rao <attilio@freebsd.org>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r234074 - in head/sys: amd64/amd64 i386/i386
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2012 13:58:26 -0000

On Monday, April 09, 2012 7:09:49 pm Marius Strobl wrote:
> On Mon, Apr 09, 2012 at 10:41:19PM +0000, Attilio Rao wrote:
> > Author: attilio
> > Date: Mon Apr  9 22:41:19 2012
> > New Revision: 234074
> > URL: http://svn.freebsd.org/changeset/base/234074
> > 
> > Log:
> >   BSP is not added to the mask of valid target CPUs for interrupts
> >   in set_apic_interrupt_ids(). Besides, set_apic_interrupts_ids() is not
> >   called in the !SMP case too.
> >   Fix this by:
> >   - Adding the BSP as an interrupt target directly in cpu_startup().
> >   - Remove an obsolete optimization where the BSP are skipped in
> >     set_apic_interrupt_ids().
> >   
> >   Reported by:	jh
> >   Reviewed by:	jhb
> >   MFC after:	3 days
> >   X-MFC:		r233961
> >   Pointy hat to:	me
> > 
> > Modified:
> >   head/sys/amd64/amd64/machdep.c
> >   head/sys/amd64/amd64/mp_machdep.c
> >   head/sys/i386/i386/machdep.c
> >   head/sys/i386/i386/mp_machdep.c
> > 
> > Modified: head/sys/amd64/amd64/machdep.c
> > 
==============================================================================
> > --- head/sys/amd64/amd64/machdep.c	Mon Apr  9 22:01:43 2012	(r234073)
> > +++ head/sys/amd64/amd64/machdep.c	Mon Apr  9 22:41:19 2012	(r234074)
> > @@ -295,6 +295,11 @@ cpu_startup(dummy)
> >  	vm_pager_bufferinit();
> >  
> >  	cpu_setregs();
> > +
> > +	/*
> > +	 * Add BSP as an interrupt target.
> > +	 */
> > +	intr_add_cpu(0);
> >  }
> 
> If I'm not mistaken, intr_add_cpu() is under #ifdef SMP, so it should be
> here as well.

Correct.  This is why I had put it in intr_machdep.c in the big #ifdef SMP 
block where all the interrupt target stuff lives.  Adding #ifdef's here is
fine as well though.

-- 
John Baldwin