From owner-cvs-src@FreeBSD.ORG  Fri Oct  1 06:08:33 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8628616A4CF; Fri,  1 Oct 2004 06:08:33 +0000 (GMT)
Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net
	[69.140.212.7])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8F2D743D54; Fri,  1 Oct 2004 06:08:31 +0000 (GMT)
	(envelope-from green@green.homeunix.org)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9168TIe001104;
	Fri, 1 Oct 2004 02:08:29 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.13.1/8.13.1/Submit) id i9168TGp001103;
	Fri, 1 Oct 2004 02:08:29 -0400 (EDT)
	(envelope-from green)
Date: Fri, 1 Oct 2004 02:08:28 -0400
From: Brian Fundakowski Feldman <green@FreeBSD.org>
To: David Schultz <das@FreeBSD.org>
Message-ID: <20041001060828.GA997@green.homeunix.org>
References: <200410010501.i9151US7086474@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200410010501.i9151US7086474@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_fork.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Oct 2004 06:08:33 -0000

On Fri, Oct 01, 2004 at 05:01:29AM +0000, David Schultz wrote:
> das         2004-10-01 05:01:29 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_fork.c 
>   Log:
>   Avoid calling _PHOLD(p1) with p2's lock held, since _PHOLD()
>   may block to swap in p1.  Instead, call _PHOLD earlier, at a
>   point where the only lock held happens to be p1's.

Since you seem to have a handle on this: how hard do you think it
would be to make all the [_]PHOLD() consumers able to handle an
error return?

Good job finding all these bugs!

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\