From owner-freebsd-doc@FreeBSD.ORG Fri Jan 7 12:30:10 2011 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1968F1065673 for ; Fri, 7 Jan 2011 12:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E22B98FC0C for ; Fri, 7 Jan 2011 12:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p07CU94V044918 for ; Fri, 7 Jan 2011 12:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p07CU9Dd044913; Fri, 7 Jan 2011 12:30:09 GMT (envelope-from gnats) Date: Fri, 7 Jan 2011 12:30:09 GMT Message-Id: <201101071230.p07CU9Dd044913@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org From: joris dedieu Cc: Subject: Re: docs/153654: [patch] incorrect include in sysctl.9 X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: joris dedieu List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 12:30:10 -0000 The following reply was made to PR docs/153654; it has been noted by GNATS. From: joris dedieu To: John Baldwin Cc: freebsd-doc@freebsd.org, freebsd-gnats-submit@freebsd.org Subject: Re: docs/153654: [patch] incorrect include in sysctl.9 Date: Fri, 7 Jan 2011 12:58:21 +0100 2011/1/3 John Baldwin : > On Monday, January 03, 2011 12:58:53 pm Joris Dedieu wrote: >> >> >Number: =A0 =A0 =A0 =A0 153654 >> >Category: =A0 =A0 =A0 docs >> >Synopsis: =A0 =A0 =A0 [patch] incorrect include in sysctl.9 >> >Confidential: =A0 no >> >Severity: =A0 =A0 =A0 non-critical >> >Priority: =A0 =A0 =A0 low >> >Responsible: =A0 =A0freebsd-doc >> >State: =A0 =A0 =A0 =A0 =A0open >> >Quarter: >> >Keywords: >> >Date-Required: >> >Class: =A0 =A0 =A0 =A0 =A0doc-bug >> >Submitter-Id: =A0 current-users >> >Arrival-Date: =A0 Mon Jan 03 18:00:24 UTC 2011 >> >Closed-Date: >> >Last-Modified: >> >Originator: =A0 =A0 Joris Dedieu >> >Release: =A0 =A0 =A0 =A08.1-RELEASE-p2 >> >Organization: >> >Environment: >> FreeBSD ladybug2.rmdir.fr 8.1-RELEASE-p2 FreeBSD 8.1-RELEASE-p2 #0: Mon = Dec 27 15:39:23 CET 2010 > joris@ladybug2.rmdir.fr:/usr/obj/usr/src/sys/GENERIC =A0amd64 >> >> >Description: >> Has DATA_SET is defined in sys/kernel.h most SYSTL_* macros don't work i= f you don't include it. >> >How-To-Repeat: >> >> >Fix: >> --- share/man/man9/sysctl.9.orig =A0 =A0 =A0 =A02011-01-03 18:43:53.0000= 00000 +0100 >> +++ share/man/man9/sysctl.9 =A0 =A0 2011-01-03 18:44:17.000000000 +0100 >> @@ -44,7 +44,7 @@ >> =A0.Nm SYSCTL_QUAD >> =A0.Nd Static sysctl declaration functions >> =A0.Sh SYNOPSIS >> -.In sys/types.h >> +.In sys/kernel.h >> =A0.In sys/sysctl.h >> =A0.Fn SYSCTL_DECL name >> =A0.Fn SYSCTL_INT parent nbr name access ptr val descr > > does not include . =A0Plus, all of > is not needed. =A0 is what defines DATA_SET(). =A0This = is > probably the "right" set of includes: > > #include > #include > #include > > OTOH, should perhaps have a nested include of > in the #ifdef _KERNEL case in which case the manpage would not need chang= ing. You are right. My patch is wrong and your solution sounds better. Should I submit an other pr ? Joris > > -- > John Baldwin >