From owner-svn-src-head@freebsd.org Tue May 31 14:40:26 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32BF3B55516 for ; Tue, 31 May 2016 14:40:26 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x22a.google.com (mail-yw0-x22a.google.com [IPv6:2607:f8b0:4002:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F08F311A9 for ; Tue, 31 May 2016 14:40:25 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x22a.google.com with SMTP id x189so190263117ywe.3 for ; Tue, 31 May 2016 07:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=+i0J8tM2a6NRYsbCBYsmgRYtBEOC8jcnuvaGJcZjMH4=; b=ftJqkqOfccT/vpoBC5hJ6QIsqF5riChuKO2HtClw5F760sQFQflTE9sWnz69w4eIFy g0vYIBxta+qJj69gSbwFxQBx2etWk8uuknBypLUp1LAgy+i/jqT74LSz7jgmNixHqbN7 vNp9Ecgx1IrBeH+uihsHa2VSizOLR4WsNnxkQyTiuKhWqYhLd+UwP/Qm2KATjPH65GEc hTz7p6Q3LL/xO6Rlzk+2WmN3Kb5Jb1Dl0Qe7AE2ubPEv9Z5pfG/Zk3RmYe0JUOQdL6qf rOTT6gyxANfw3X5udn2T810Xi96fD5ze3FBzu7thxFQzQM4tWMa5VaWgc6/a8oVt7ZzF pbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=+i0J8tM2a6NRYsbCBYsmgRYtBEOC8jcnuvaGJcZjMH4=; b=JPCmJnbmDJfzkoEarIg9YcQ3mjk0z7C1gvSwTaYQ+7IReiNgF/eg/KXhcgPua53KyD gHk7r2xRM+FVO7wnX+OPuytt9dpPcgxYTjaaPTVQ8p8U68gTH8hzQu/EdWfSIHuz9fsB V/18cZpEPvDvSN1gY6fjAMUpGS3lOVwhMopyIegXKapZKVwz9OAA7EiD6soSyv9f0BmO vUsb0Ob5tGnripoQB4FKT1oFyxbTmZ0Tb7QzAhem7/SWI65ea1NrU9E7KIfvVW7sWIYe r2qaZX9TuBRsciSnQWqrMtRN1lYCzEeuCQhiu0bczMcnYGeMZqQSq2smF13YNC+FTPjS 1biA== X-Gm-Message-State: ALyK8tJBCWGI2oOa9d9n7qaQvWQpVrNv7pMbB+grd0J4mom2VXBJxq3jm6Ttu3qIsOutoctNiKSpVsXD1E4M1Q== MIME-Version: 1.0 X-Received: by 10.129.53.70 with SMTP id c67mr21900602ywa.149.1464705624932; Tue, 31 May 2016 07:40:24 -0700 (PDT) Received: by 10.13.201.199 with HTTP; Tue, 31 May 2016 07:40:24 -0700 (PDT) In-Reply-To: <574C7E89.3080102@FreeBSD.org> References: <201605301652.u4UGqNeu070540@repo.freebsd.org> <574C7E89.3080102@FreeBSD.org> Date: Tue, 31 May 2016 16:40:24 +0200 Message-ID: Subject: Re: svn commit: r300999 - in head: include lib/libc/db/man From: Ed Schouten To: Pedro Giffuni Cc: Ed Schouten , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 14:40:26 -0000 2016-05-30 19:55 GMT+02:00 Pedro Giffuni : > IMHO, just before a new release is the perfect time to break the ABI, and > POSIX > is a good reason to do it. I thought about it a bit more and switching this over to size_t will only cause breakage on 64-bit big endian platforms. On 32-bit systems this would have no effect. On 64-bit little endian systems, we'd still load the bottom four bytes, which is all right. We could use symbol versioning to deal with this, but I don't think it's worth the effort. I've sent out a code review to both of you: https://reviews.freebsd.org/D6660 If anyone wants to share their thoughts on the proposed change, feel free to leave a comment. I'll hold off for a couple of days before submitting. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717