From owner-svn-src-head@FreeBSD.ORG Wed Oct 8 20:10:22 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B11D9F97; Wed, 8 Oct 2014 20:10:22 +0000 (UTC) Received: from mail-la0-x232.google.com (mail-la0-x232.google.com [IPv6:2a00:1450:4010:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A72617B1; Wed, 8 Oct 2014 20:10:21 +0000 (UTC) Received: by mail-la0-f50.google.com with SMTP id s18so9170274lam.23 for ; Wed, 08 Oct 2014 13:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=wjvJHltr3mx6cWmzaspEEztRPg6NmedA0yccs0Bcd4s=; b=z36283Ea7Tc+VxoOTMNBR/BbKGs4rIPbh4dY7ekqG2ygExnSfn6jcSCHDXvx2sbFGH +HoLRFxfu47nYzVyF4GzDOs4LddlMYWc8LSS3jvW9xYgInAoSnmVCB9aSswx0ueqSWAK 8nv/6dgfitlfD/Ioqx8W1pUgyioU2WO7M+LKZUjdiUSN5Aq9jjVcFg7s+AhOajj/zbJP HuEqSVScmKEBecuWFPkP5vR8l0mPhMsGncYe7KpfdYrQD7WgLNhrlOOxmSbuhS1TK/1n D8D8r2wYb0E9QSI3NB7EOSq/XN6LtSatzSdr3Ryk8EGgCekz7rLgtyvyduYtT0sFDItA QgAA== MIME-Version: 1.0 X-Received: by 10.112.205.39 with SMTP id ld7mr13079771lbc.40.1412799019434; Wed, 08 Oct 2014 13:10:19 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.131.66 with HTTP; Wed, 8 Oct 2014 13:10:19 -0700 (PDT) In-Reply-To: <20141007223941.GT37670@ivaldir.etoilebsd.net> References: <201410061443.s96Eh2Jn022718@svn.freebsd.org> <20141006144924.GB37670@ivaldir.etoilebsd.net> <20141007223941.GT37670@ivaldir.etoilebsd.net> Date: Wed, 8 Oct 2014 13:10:19 -0700 X-Google-Sender-Auth: mIgrZNbkAlroSRA_bPTT3Z3ygGs Message-ID: Subject: Re: svn commit: r272649 - head/contrib/byacc From: Craig Rodrigues To: Baptiste Daroussin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Oct 2014 20:10:22 -0000 On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin wrote: > On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: > > On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin > wrote: > > > > > > > > Why a direct commit instead of a proper import of 20141005 version? it > > > would > > > have imho been better, simpler and easier to maintain. > > > > > > > Because according to Thomas Dickey, he did not fix all > > the memory related problems in snapshot 20141005. Specifically there are > > still > > some issues not fixed when realloc() is called. > > I was going to wait for the next snapshot. > > However, I wanted to get that one fix into FreeBSD to fix the kyua tests, > > which have been failing under Jenkins. See: > > https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ > > (see runs #10 and #11). > > In that case I will import the new one which has the fix (do you confirm?) > According to http://invisible-island.net/byacc/CHANGES.html , the 2014-10-06 has a fix to address my concerns. However, this fix involves a lot of changes to the code, and I don't have time right now to audit everything. There have been a lot of changes to the byacc code in the past few days. The changes are good bugfixes, but I would recommend auditing everything beore importing the snapshot into FreeBSD. -- Craig