Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Oct 2019 17:31:27 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Gleb Smirnoff <glebius@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, br@freebsd.org
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r353876 - head/sys/kern
Message-ID:  <55116590-d3ca-00ea-29c6-f32adfcdea9e@selasky.org>
In-Reply-To: <20191022152913.GJ4086@FreeBSD.org>
References:  <201910212312.x9LNCEbX052414@repo.freebsd.org> <CAKBkRUzTs%2BSpUr0AFoj%2Bmt2im_0TDDc5bq-E0N5SwAV%2BV7BpEQ@mail.gmail.com> <20191022152913.GJ4086@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-22 17:29, Gleb Smirnoff wrote:
> L>
> L> panic: Assertion (vm_offset_t)et >= td->td_kstack && (vm_offset_t)et +
> L> sizeof(struct epoch_tracker) < td->td_kstack + td->td_kstack_pages *
> L> PAGE_SIZE failed at /workspace/src/sys/kern/subr_epoch.c:373

Probably doesn't matter that much, but the last comparison should be 
less than or equal, instead of only less than, off-by-one, if the 
element is on top of stack ???

sizeof(struct epoch_tracker) XXX <= XXX td->td_kstack + td->td_kstack_pages

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55116590-d3ca-00ea-29c6-f32adfcdea9e>