From owner-cvs-src@FreeBSD.ORG Sat Mar 11 02:01:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCBE916A572; Sat, 11 Mar 2006 02:01:47 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 365E644B62; Fri, 10 Mar 2006 13:39:31 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 8242A209E; Fri, 10 Mar 2006 14:39:26 +0100 (CET) X-Spam-Tests: AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Learn: ham X-Spam-Score: -2.4/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id F0A8F2086; Fri, 10 Mar 2006 14:39:25 +0100 (CET) Received: by xps.des.no (Postfix, from userid 1001) id B1D5533C31; Fri, 10 Mar 2006 14:39:25 +0100 (CET) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Ruslan Ermilov References: <200603090133.k291XcfB005631@repoman.freebsd.org> <20060309090307.GK54826@ip.net.ua> Date: Fri, 10 Mar 2006 14:39:25 +0100 In-Reply-To: <20060309090307.GK54826@ip.net.ua> (Ruslan Ermilov's message of "Thu, 9 Mar 2006 11:03:07 +0200") Message-ID: <864q262zci.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2006 02:01:53 -0000 Ruslan Ermilov writes: > On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote: > > Log: > > Now that we now spell NO_MAN=3Dxxx MAN=3D, update the docs. > I object. > > 1) This is not common: > > grep '^NO_MAN=3D' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l > 10 > grep '^MAN=3D[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile = |wc -l > 0 > > 2) MAN=3D is worse for performance (with NO_MAN, bsd.man.mk is not > processes at all which is faster). > > 3) This is in contrast with NO_OBJ and similar knobs. > > I can only suggest to make it spell "NO_MAN=3D", i.e., without any value. > > Was there some discussion that I've missed? I was told long ago (shortly after we switched from MAN[1-9] to just MAN, I believe) that NO_MAN was wrong, and the correct way was to define MAN to an empty value. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no