From owner-freebsd-ports@FreeBSD.ORG Sun Jan 16 21:49:09 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01557106566C for ; Sun, 16 Jan 2011 21:49:09 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id D00F98FC0C for ; Sun, 16 Jan 2011 21:49:08 +0000 (UTC) Received: from mail.experts-exchange.com (localhost [127.0.0.1]) by mail.experts-exchange.com (Postfix) with ESMTP id 9F13F12662C5; Sun, 16 Jan 2011 13:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=e-e.com; h= user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:content-type:mime-version :references:message-id:subject:subject:from:from:date:date :received:received:received; s=ee; t=1295214548; x=1297028948; bh=+W857/w4O/8jatttcZ4jHqP8QR4nduYx/rRIK7RJLBA=; b=Xtux/a/Ga8+J IEeDV7b4aIjC4kUkEdkhzBgQg+zyzWpZyhP4+oyO1+CClyp2u+kCR0O/3RMgoQRW DKHag+ocMobljsAPc94FTmKkZJehCFRZKE/ATrpA0SfunG34ZwVVstkMfyJ1PBKO Qv3kSzXpOlrtOCcz9s30H57nxOJhRoU= X-Virus-Scanned: amavisd-new at experts-exchange.com Received: from mail.experts-exchange.com ([127.0.0.1]) by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7UMMyW6Gk-DD; Sun, 16 Jan 2011 13:49:08 -0800 (PST) Received: from experts-exchange.com (unknown [192.168.103.122]) by mail.experts-exchange.com (Postfix) with SMTP id 5059012662C4; Sun, 16 Jan 2011 13:49:08 -0800 (PST) Received: (nullmailer pid 2267 invoked by uid 1001); Sun, 16 Jan 2011 21:45:57 -0000 Date: Sun, 16 Jan 2011 13:45:57 -0800 From: Jason Helfman To: Ruslan Mahmatkhanov Message-ID: <20110116214557.GA2179@eggman.experts-exchange.com> References: <11111295127072@web122.yandex.ru> <4D3329FE.7020901@yandex.ru> <20110116204416.GA1654@eggman.experts-exchange.com> <4D3361B3.40201@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4D3361B3.40201@yandex.ru> X-Operating-System: FreeBSD 8.1-RELEASE X-Living-The-Dream: I love the SLO Life! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: ports@freebsd.org Subject: Re: New port needs review: net/erlyvideo X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 21:49:09 -0000 On Mon, Jan 17, 2011 at 12:22:59AM +0300, Ruslan Mahmatkhanov thus spake: >16.01.2011 23:44, Jason Helfman пишет: >> On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: >As you can see this patch indeed eliminates using of git, because this >part isn't really needed for erlyvideo to work. > Read this wrong. Thanks, for pointing this out. >> You may wish to consider a for loop on the make install target. >> Are these directories created during the install process of the package? I >> didn't see these directories created outside of the Makefile. > >Do you mean something like this? > >DIRS= /var/lib/${PORTNAME}/movies /var/lib/${PORTNAME}/plugins \ > /var/log/${PORTNAME} ${ERLYDIR} ${ETCDIR} ${WWWDIR} >.for dir in ${DIRS} > ${MKDIR} ${dir} >.endfor Yes, however are they created during a pkg_add command? Consider a recent patch I submitted for comms/minicom. http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153749 Directories created in Makefile process, aren't created in the packaging process, unless you are putting the operations into a pkg-install or an @exec operation in pkg-plist, respectively. That is my understanding, and what I have found in fixing ports here and there. I fixed the packaging for www/tomcat55, as well. I found that as a port it worked fine, however package installation would fail. > >> >> I noticed many '.gitignore' files in the pkg-plist. Is this necessary? I've >> never worked with git before, or this application. > >No, it isn't needed. I'll try to delete them before install. If it is included in the source, you can just add a post-patch operation that does a find and removes them, and remove them from the pkg-plist, as well. > >> When submitting this as a port through the PR system, I would suggest using >> the shar utility: > >Yep, i know. I post the diff just to make it easy to comment in email. I see. Good idea. > >> >> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html >> >> >> -jgh >> > >Thank you for your suggestions! Your very welcome. Best regards, Jason -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5