From owner-cvs-src@FreeBSD.ORG  Thu Jun 17 17:39:17 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 688D616A4CE; Thu, 17 Jun 2004 17:39:17 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 35B6F43D5F; Thu, 17 Jun 2004 17:39:17 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id D4BED5C7BD; Thu, 17 Jun 2004 10:38:54 -0700 (PDT)
Date: Thu, 17 Jun 2004 10:38:54 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Max Khon <fjoe@FreeBSD.org>
Message-ID: <20040617173854.GJ61448@elvis.mu.org>
References: <200406170008.i5H08NDt085108@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200406170008.i5H08NDt085108@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf.c
	uipc_syscalls.c src/usr.bin/netstat mbuf.c src/lib/libc/sys
	sendfile.2
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jun 2004 17:39:17 -0000

MFC'ing a change to netstat -m's output is not acceptable.

This will break scripts.

Please back out the netstat change.

Why are sfbuf/sendfile stats being put under mbuf stats?

This is bogus, please use a different flag instead of cluttering
the mbuf stats.



* Max Khon <fjoe@FreeBSD.org> [040616 17:08] wrote:
> fjoe        2004-06-17 00:08:23 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:        (Branch: RELENG_4)
>     sys/sys              mbuf.h 
>     sys/kern             uipc_mbuf.c uipc_syscalls.c 
>     usr.bin/netstat      mbuf.c 
>     lib/libc/sys         sendfile.2 
>   Log:
>   MFC:
>   
>   sendfile(2)-related statistics that can be viewed through netstat -m:
>   - The number of times sendfile() had to do disk I/O
>   - The number of times sfbuf allocation failed
>   - The number of times sfbuf allocation had to wait
>   and three sysctl's: kern.ipc.nsfbufs, kern.ipc.nsfbufspeak,
>   kern.ipc.nsfbufsused that also can be viewed through netstat -m.
>   
>   Submitted by:   Igor Sysoev <is (at) rambler-co.ru>
>   
>   Revision   Changes    Path
>   1.6.2.9    +50 -1     src/lib/libc/sys/sendfile.2
>   1.51.2.37  +8 -0      src/sys/kern/uipc_mbuf.c
>   1.65.2.20  +6 -0      src/sys/kern/uipc_syscalls.c
>   1.44.2.26  +6 -1      src/sys/sys/mbuf.h
>   1.17.2.4   +16 -2     src/usr.bin/netstat/mbuf.c

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684