From owner-cvs-all Mon Oct 21 12: 6:28 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 308BB37B401; Mon, 21 Oct 2002 12:06:27 -0700 (PDT) Date: Mon, 21 Oct 2002 12:06:27 -0700 From: Juli Mallett To: Poul-Henning Kamp Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa npx.c Message-ID: <20021021120627.A81874@FreeBSD.org> References: <20021021110058.Y8562-100000@gamplex.bde.org> <66391.1035178586@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <66391.1035178586@critter.freebsd.dk>; from phk@critter.freebsd.dk on Mon, Oct 21, 2002 at 07:36:26AM +0200 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Poul-Henning Kamp [ Data: 2002-10-20 ] [ Subjecte: Re: cvs commit: src/sys/i386/isa npx.c ] > In message <20021021110058.Y8562-100000@gamplex.bde.org>, Bruce Evans writes: > >On Sun, 20 Oct 2002, Poul-Henning Kamp wrote: > > > >> phk 2002/10/20 10:30:30 PDT > >> > >> Modified files: > >> sys/i386/isa npx.c > >> Log: > >> Hide inline assembly if lint is defined. > >> > >> Revision Changes Path > >> 1.133 +1 -1 src/sys/i386/isa/npx.c > > > >Inline assembly was already correctly hidden by a __GNUC__ ifdef. It > >is a feature that broken lints which define __GNUC__ without actually > >being supporting all features of gcc barf on unsupported features. > >Please back this out. > > Our kernel is too __GNUC__ infected to making linting it without > defining __GNUC__ an option. > > At the present time, no other compiler stands a chance at compiling > our kernel, and it therefore seems far more productive to be able > to run lint on the code we have and use, than the code we don't have > and don't use. This breaks linters which look at __asm__ to find assignment/initialisation and could result in spurious "used before initialisation" messages and the like. -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message