Date: Mon, 23 Aug 2010 08:07:59 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: hackers@freebsd.org, Garrett Cooper <gcooper@freebsd.org> Subject: Re: Question about printcpuinfo in sys/amd64/amd64/indentcpu.c Message-ID: <201008230807.59582.jhb@freebsd.org> In-Reply-To: <AANLkTi=CB4eyZPsj%2BNdFfYo3bhQ-P=1icnxAHx3VaT%2Bn@mail.gmail.com> References: <AANLkTi=CB4eyZPsj%2BNdFfYo3bhQ-P=1icnxAHx3VaT%2Bn@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, August 20, 2010 10:14:46 am Garrett Cooper wrote:
> Hi,
> Currently the code in identcpu.c does a check for a specific cpu
> value extension. This is set to 0x80000004 (even though the
> corresponding code below iterates through 0x80000002:0x80000005):
It does not invoke 0x80000005 (<, not <=, is used as the loop terminator).
> /* Check for extended CPUID information and a processor name. */
> if (cpu_exthigh >= 0x80000004) {
> brand = cpu_brand;
> for (i = 0x80000002; i < 0x80000005; i++) {
> do_cpuid(i, regs);
> memcpy(brand, regs, sizeof(regs));
> brand += sizeof(regs);
> }
> }
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008230807.59582.jhb>