From owner-freebsd-bugs Fri Mar 21 22:36: 3 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6148C37B401; Fri, 21 Mar 2003 22:36:02 -0800 (PST) Received: from 134.216-123-229-0.interbaun.com (134.216-123-229-0.interbaun.com [216.123.229.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id B771343FDD; Fri, 21 Mar 2003 22:36:00 -0800 (PST) (envelope-from soralx@cydem.org.ua) Received: from vasya (vasya [192.168.0.3]) by 134.216-123-229-0.interbaun.com (8.11.6/8.11.6) with ESMTP id h2M6ZvU28790; Fri, 21 Mar 2003 23:35:59 -0700 (MST) (envelope-from soralx@cydem.org.ua) From: To: freebsd-bugs@FreeBSD.ORG Subject: Re: misc/41772: can't disable keybell [PATCH] Date: Fri, 21 Mar 2003 23:25:38 -0700 User-Agent: KMail/1.5 References: <200303150816.h2F8Ghr2039611@freefall.freebsd.org> In-Reply-To: <200303150816.h2F8Ghr2039611@freefall.freebsd.org> Cc: freebsd-hackers@FreeBSD.ORG, dougb@FreeBSD.ORG MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200303212321.30894.soralx@cydem.org.ua> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org > http://www.freebsd.org/cgi/query-pr.cgi?pr=41772 This appears to be _VERY_ old problem (I don't remember it on 2.2.7-RELEASE, though) In short: the beeper still produces noises (clicks) when shut up with `kbdcontrol -b off` Finally I got some time to look at 'sys/dev/syscons/syscons.c'. However, I only speak i386 Asm fluently (no C at all yet), so could someone plz (fix?) this 3-line 'patch' and commit it? I'd really like to see it MFC'ed in 4.8-RELEASE (as well a this one: 'http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/44257' - it works well for my EIDE controller). FreeBSD 4.6.2-RELEASE: =======================8<======================= --- ./syscons.c.ORIG Fri Mar 21 23:10:05 2003 +++ ./syscons.c Fri Mar 21 23:10:37 2003 @@ -3385,6 +3385,9 @@ if (scp != scp->sc->cur_scp && (scp->sc->flags & SC_QUIET_BELL)) return; + if (!(duration && pitch)) + return; + if (scp->sc->flags & SC_VISUAL_BELL) { if (scp->sc->blink_in_progress) return; =======================8<======================= 21.03.2003; 23:20:26 [SorAlx] http://cydem.org.ua/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message