From owner-svn-src-head@freebsd.org Thu Jun 23 16:55:07 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C08FFB73CAE; Thu, 23 Jun 2016 16:55:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A0F052D70; Thu, 23 Jun 2016 16:55:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B8DD2B945; Thu, 23 Jun 2016 12:55:06 -0400 (EDT) From: John Baldwin To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302094 - in head/sys: compat/freebsd32 kern Date: Thu, 23 Jun 2016 09:52:58 -0700 Message-ID: <1867573.VqAxCqRXft@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.3-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20160623003948.GB41630@spindle.one-eyed-alien.net> References: <201606222115.u5MLFxBD093628@repo.freebsd.org> <5096414.4TN0ypqLNM@ralph.baldwin.cx> <20160623003948.GB41630@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 23 Jun 2016 12:55:06 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 16:55:07 -0000 On Thursday, June 23, 2016 12:39:48 AM Brooks Davis wrote: > On Wed, Jun 22, 2016 at 05:09:34PM -0700, John Baldwin wrote: > > On Wednesday, June 22, 2016 09:15:59 PM Brooks Davis wrote: > > > Author: brooks > > > Date: Wed Jun 22 21:15:59 2016 > > > New Revision: 302094 > > > URL: https://svnweb.freebsd.org/changeset/base/302094 > > > > > > Log: > > > Mark the pipe() system call as COMPAT10. > > > > > > As of r302092 libc uses pipe2() with a zero flags value instead of pipe(). > > > > > > Commit with regenerated files and implementation to follow. > > > > This breaks the build on at least i386 because other ABIs depend on being > > able to call sys_pipe directly. You should at least add COMPAT_FREEBSD10 > > to GENERIC on architectures that shipped a 10.x release. That will fix the > > build breakage on i386, but it's also the policy we follow for all the other > > compat knobs. > > It was actually that sys_pipe() was renamed by the COMPAT10 tag. I've > copied the implementation to a svr4_pipe(). Thanks, my bad for jumping the gun on assuming FREEBSD10 was missing from GENERIC. -- John Baldwin