From nobody Thu Aug 14 01:47:29 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c2SmK6fx1z64rrc; Thu, 14 Aug 2025 01:47:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c2SmK60pKz42wt; Thu, 14 Aug 2025 01:47:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755136049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lVAIdSSIKwEHkdcgakTep3Dz8HLUiiLqBr5FZO/xATQ=; b=yCWY0AbqkTPv4wOJXF4F5dZSIJWtBNMA5ENv3X348HbhjlKceU553E+0CehmSLCE1L/N/K dRC7tL26ECTK9SpdgJNHCqFryxd6kP8gaLySxDeM5DsvAM3AAaEFdFk1Y1ReIshjNlRPiB 7WR+GbwHL4ue78Q1iFhvE389D61dBjH+tWcaaj+L2J4PSwMe0ml5rnunOhaNeOwbriGIQh vZ9TMlhpO8kouyvbkwRNL7EO1X473+jpYWSlhp5H8Yy6/XSSZmoehQUG9UCf7EGgcuKfba Yu8kr3tXwHCI4MWDnIMdXYkrTg2FNyUV8grwB7R7aeB+Bul0hax0OsqI/peglg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755136049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lVAIdSSIKwEHkdcgakTep3Dz8HLUiiLqBr5FZO/xATQ=; b=kaYBFb3a90YgV1zwt9CF/joq3WavegSLBsNm/z6imlEBSWVOIx1JbFBPSfsJajb7FAj0Ws 7lfSWZNYzf5NOwsBUjChBQTWO8pzaxE9id+aJm+Vtz7FvS3llEq6BV8LZcZ92X0MKFJ27M 3j0IjhTKWj/ArN95Z2OL/Ptme3AtNKJcW6YI78BbsP5cVR9DbBgX5giOsTAhvYjCiFcXEH EqD+urcwZmx/R4Rwy1DYgPALk1SEkrawMnrsJD19A/6wzxpfCzAmJAEC9uMw/vkNBJTc9P jhH9/9AaZ9dOQdxyspMSz8uQLEWD4d7PJN42Er3vVZ07senN+UpLKjg42MVtrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755136049; a=rsa-sha256; cv=none; b=MOAkkGeLbXJ5EeSflTR2Vo3yIblPITn/EQxpXygHd7hdAjjVVSZEU0DOW+OO9X+jkDp8K6 SqQeUJpB/1Eu/1yf+8xqJtIav8PB5btqfLhzKYlmLI+88KakE6w1JUIyQ0S5+gG1y8On3j AU5wAXpLhBTe8ROWBDO6x77+KY6KlOLHlqDHyf62q8bMwz78WSbAsb84svRKTCr2qZ27DB eDKOYKCVPJXyVz9xWUW9Alr7qUUENoUShf+Ber3dOh/lbbc9AUeS71t9Z9zPXNbGrHashY pyn5Yw+bsYLV6qVcGpg5MXy51JZ8Dt1Utb2SV4J+C7PEyew5tmuaG+K67HJhkw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c2SmK5bv2zYpY; Thu, 14 Aug 2025 01:47:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57E1lTYL058824; Thu, 14 Aug 2025 01:47:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57E1lTVj058821; Thu, 14 Aug 2025 01:47:29 GMT (envelope-from git) Date: Thu, 14 Aug 2025 01:47:29 GMT Message-Id: <202508140147.57E1lTVj058821@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric van Gyzen Subject: git: 5c5bb958fc82 - main - mlx5: plug theoretical leak in vxlan rules List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vangyzen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5c5bb958fc823215cfb5a71c1ac7b6d9d93c0701 Auto-Submitted: auto-generated The branch main has been updated by vangyzen: URL: https://cgit.FreeBSD.org/src/commit/?id=5c5bb958fc823215cfb5a71c1ac7b6d9d93c0701 commit 5c5bb958fc823215cfb5a71c1ac7b6d9d93c0701 Author: Eric van Gyzen AuthorDate: 2025-08-12 14:51:38 +0000 Commit: Eric van Gyzen CommitDate: 2025-08-14 01:47:14 +0000 mlx5: plug theoretical leak in vxlan rules Plug a theoretical memory/refcount leak when adding a vxlan rule. This is not currently an actual leak, but it could become one. PR: 287945 Reviewed by: kib Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D51883 --- sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c b/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c index 6e24395b5577..c45f02cdaf42 100644 --- a/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c @@ -1783,8 +1783,8 @@ mlx5e_add_vxlan_rule(struct mlx5e_priv *priv, sa_family_t family, u_int port) el->refcount++; if (el->installed) return (0); - } - el = mlx5e_vxlan_alloc_db_el(priv, proto, port); + } else + el = mlx5e_vxlan_alloc_db_el(priv, proto, port); if ((if_getcapenable(priv->ifp) & IFCAP_VXLAN_HWCSUM) != 0) { err = mlx5e_add_vxlan_rule_from_db(priv, el);