From owner-freebsd-bugs@freebsd.org  Mon Aug 22 14:12:27 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3015BC2DEF
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Mon, 22 Aug 2016 14:12:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DBC461307
 for <freebsd-bugs@FreeBSD.org>; Mon, 22 Aug 2016 14:12:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7MECQYU048015
 for <freebsd-bugs@FreeBSD.org>; Mon, 22 Aug 2016 14:12:26 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 212033] fgetwln(3) fails to report most encoding errors
Date: Mon, 22 Aug 2016 14:12:27 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: schwarze@usta.de
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-212033-8-zM4vPgS2PC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-212033-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-212033-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2016 14:12:27 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212033

--- Comment #3 from Ingo Schwarze <schwarze@usta.de> ---
(In reply to Andrey Chernov from comment #1)

> The check miss one condition:  [...]  wc =3D=3D WEOF

Checking wc is needless; it's even safer to *not* check it.
When the error indicator is set, fgetwln(3) should better fail.

Regarding fgetwc(3), POSIX says: "If an error occurs, the resulting value of
the file position indicator for the stream is unspecified."  The OpenBSD ma=
nual
says: "The end-of-file condition is remembered, even on a terminal, and all
subsequent attempts to read will return WEOF until the condition is cleared
with clearerr(3)."

So, as soon as the error indicator goes up, all bets are off for reading fr=
om
the stream.  In that case, fgetwc(3) is expected to always fail.  And even =
if
it happened not too, that would just be weird, and fgetwln(3) should better
fail anyway.

--=20
You are receiving this mail because:
You are the assignee for the bug.=