From owner-svn-src-all@FreeBSD.ORG Tue Dec 31 03:22:09 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 75F26123 for ; Tue, 31 Dec 2013 03:22:09 +0000 (UTC) Received: from nm4.bullet.mail.bf1.yahoo.com (nm4.bullet.mail.bf1.yahoo.com [98.139.212.163]) by mx1.freebsd.org (Postfix) with SMTP id 084AF1A4D for ; Tue, 31 Dec 2013 03:22:08 +0000 (UTC) Received: from [98.139.212.153] by nm4.bullet.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:22:01 -0000 Received: from [98.139.211.206] by tm10.bullet.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:22:00 -0000 Received: from [127.0.0.1] by smtp215.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:22:00 -0000 X-Yahoo-Newman-Id: 976141.96410.bm@smtp215.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Thkt8PIVM1kEaiFSX68uXeeB5FSV2CCHrzH4uEIKSkPZ24e KAXATPh8M_NboE6RgSoASTCIGVs7h_plBXl.Tw6Z3L0SCytFvl17jGX0khpp JQRKuBRgSamZCu.DmNt0LHybyr1jclpS9BjGBJnn0v8zQ.MfIrhNRGAnkwNp Ff5wtgkuMgL1D9vAVAPYN.6.oID7IN4.TpdQmtTlE1vb3lcwZcFkarfEJOec MkzgjOBYGEE_O01SWmkgoDewXPcw4q5MhcdsvFXweB.iZgfu4D6k4S1bzx6A 3sXi8k74eMS9RDOBDLjHUaYFj7VIsHO7hyDbgJKmw_d9ZwfwsFC.3B82WHOz E_1eEj1Kaq3uohrKpPqQxs7DYUP66Iybwx5YBbv5FHaDRuTFX4ugIVMsWOqk H5_mwtC534h0Q8dtsL3n5By8HEKPz5CnB2wllrGF7NW36xMsuXaCFWD3iqm. 3RhJ1zBQf8SP5rbstG26vse9zR.NcRVyiHfU548gFNWhK8KyLwHrNhqVfylg FZf752vRbXwQ8O7F3H.jUlyp84U0lUnWhEQqkmC3Cz8_IUxMJI2I- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.101] (pfg@190.157.126.109 with plain [98.139.211.125]) by smtp215.mail.bf1.yahoo.com with SMTP; 30 Dec 2013 19:22:00 -0800 PST Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: svn commit: r260091 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace contrib/opensolaris/uts/common/sys dev/dtrace From: Pedro Giffuni In-Reply-To: <20131231023952.GA11997@charmander.home> Date: Mon, 30 Dec 2013 22:21:58 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <7A335B4A-D986-4E6E-8D8B-22E7E7991A75@FreeBSD.org> References: <201312301737.rBUHbW3I035088@svn.freebsd.org> <20131230204210.GD71033@FreeBSD.org> <20131231023952.GA11997@charmander.home> To: Mark Johnston X-Mailer: Apple Mail (2.1822) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , Mike Ma , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2013 03:22:09 -0000 Il giorno 30/dic/2013, alle ore 21:40, Mark Johnston = ha scritto: > On Tue, Dec 31, 2013 at 12:42:10AM +0400, Gleb Smirnoff wrote: >> On Mon, Dec 30, 2013 at 05:37:32PM +0000, Mark Johnston wrote: >> M> Author: markj >> M> Date: Mon Dec 30 17:37:32 2013 >> M> New Revision: 260091 >> M> URL: http://svnweb.freebsd.org/changeset/base/260091 >> M>=20 >> M> Log: >> M> Now that vmem(9) is available, use vmem arenas to allocate probe = and >> M> aggregation IDs, as is done in the upstream illumos code. This = still >> M> requires some FreeBSD-specific code, as our vmem API is not = identical to the >> M> one in illumos. >> M> =20 >> M> Submitted by: Mike Ma >>=20 >> IMHO, alloc_unr() was lighter and thus better for allocating just = IDs. >=20 > That's true; I committed the change since it helps keep our code = similar > to upstream and, as Pedro notes, it was a long-standing todo item on = the > wiki. After doing some testing, it looks like vmem is a bit slower: > process startup is on the order of tenths of milliseconds longer with > this change, for executables containing one USDT probe (since such > probes are allocated during process startup). >=20 > So probably the right thing to do is revert this change. It doesn't > actually reduce the upstream diff as much as I'd hoped, anyway. >=20 Since it is our option to decide, perhaps just keep the vmem version as = reference and #ifdef FreeBSD alloc_unr() ? I don=92t think we need to keep most of those SUN defines anymore. Pedro. > Thanks, > -Mark