From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Feb 7 10:10:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C77C16A421 for ; Thu, 7 Feb 2008 10:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D46FB13C45E for ; Thu, 7 Feb 2008 10:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m17AA0Xn053409 for ; Thu, 7 Feb 2008 10:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m17AA0Oq053408; Thu, 7 Feb 2008 10:10:00 GMT (envelope-from gnats) Resent-Date: Thu, 7 Feb 2008 10:10:00 GMT Resent-Message-Id: <200802071010.m17AA0Oq053408@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan `Sec` Zehl Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A5AE16A419; Thu, 7 Feb 2008 10:08:03 +0000 (UTC) (envelope-from sec@42.org) Received: from ice.42.org (v6.42.org [IPv6:2001:608:9::1]) by mx1.freebsd.org (Postfix) with ESMTP id 308AE13C457; Thu, 7 Feb 2008 10:08:03 +0000 (UTC) (envelope-from sec@42.org) Received: by ice.42.org (Postfix, from userid 1000) id 92003B848; Thu, 7 Feb 2008 11:08:00 +0100 (CET) Message-Id: <20080207100800.92003B848@ice.42.org> Date: Thu, 7 Feb 2008 11:08:00 +0100 (CET) From: Stefan `Sec` Zehl To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: torstenb@FreeBSD.org Subject: ports/120340: port irc/ircII broken on amd64/7.0R [patch included] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stefan `Sec` Zehl List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2008 10:10:01 -0000 >Number: 120340 >Category: ports >Synopsis: port irc/ircII broken on amd64/7.0R [patch included] >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Feb 07 10:10:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Stefan `Sec` Zehl >Release: FreeBSD 7.0-PRERELEASE amd64 >Organization: >Environment: System: FreeBSD ice 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Wed Feb 6 12:55:25 UTC 2008 sec@ice:/usr/obj/usr/src/sys/GENERIC amd64 >Description: irc/ircII is marked broken on RELENG_7 / amd64 with "doesn't build" During the build process "mksiginc" core dumps because of a write outside allocated memory. The problem is, that it allocates an array of NSIG entries, but writes to SIGRTMAX. At least on RELENG_7 / amd64, SIGRTMAX is way bigger than NSIG so this (correctly) fails. I fixed this, by increasing the array size to SIGRTMAX. ircII appears to compile and run without any further problems after this fix. >How-To-Repeat: >Fix: put the following patch into irc/ircII/files/patch-amd64 and remove the BROKEN= part from the Makefile :-) --- source/mksiginc.c.orig 2004-02-16 10:00:58.000000000 +0000 +++ source/mksiginc.c 2008-02-07 09:53:07.000000000 +0000 @@ -39,7 +39,11 @@ #define NSIG 64 #endif +#if defined(SIGRTMAX) && (SIGRTMAX > NSIG) +#define MAXSIG SIGRTMAX+1 +#else #define MAXSIG NSIG+1 +#endif char *signames[MAXSIG]; int main(int, char *[], char *[]); >Release-Note: >Audit-Trail: >Unformatted: