From owner-freebsd-arm@freebsd.org Fri Sep 25 00:54:32 2015 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72131A086ED for ; Fri, 25 Sep 2015 00:54:32 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 50EB11839 for ; Fri, 25 Sep 2015 00:54:32 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 25 Sep 2015 00:55:08 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t8P0sSgM004355; Thu, 24 Sep 2015 18:54:29 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1443142468.1224.322.camel@freebsd.org> Subject: Re: NFS Root with Raspberry Pi (nfs_diskless: no interface) From: Ian Lepore To: Hans Petter Selasky Cc: Randy Westlund , freebsd-arm@freebsd.org, Rick Macklem Date: Thu, 24 Sep 2015 18:54:28 -0600 In-Reply-To: <560438C5.3090404@selasky.org> References: <20150922052522.GA62140@gmail.com> <00C49FEB-E8EF-4469-85E2-0F901215CD11@cs.huji.ac.il> <20150923050414.GB43653@gmail.com> <91AAC64E-4C38-47AA-8910-48F7654A7524@cs.huji.ac.il> <20150923174445.GE43653@gmail.com> <1443105426.1224.272.camel@freebsd.org> <20150924163658.GC32257@gmail.com> <560438C5.3090404@selasky.org> Content-Type: multipart/mixed; boundary="=-JFrIpY5MfS0yWt+nRO0J" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 00:54:32 -0000 --=-JFrIpY5MfS0yWt+nRO0J Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 2015-09-24 at 19:54 +0200, Hans Petter Selasky wrote: > On 09/24/15 18:36, Randy Westlund wrote: > > On Thu, Sep 24, 2015 at 08:37:06AM -0600, Ian Lepore wrote: > > >>>[orig problem description: basically nfsroot without BOOTP fails] > > >> Try setting boot.netif.name="ue0" in loader.conf. I've never tried > >> that, but in looking at the code, there's some chance it could work. :) > >> > >> What I do is put these options into my RPi kernel config: > >> > >> options BOOTP > >> options BOOTP_NFSROOT > >> options BOOTP_NFSV3 > >> options BOOTP_WIRED_TO=ue0 > >> > >> But this requires configuring a bootp or dhcp server to provide the > >> info. It should be possible to netboot without using BOOTP. > >> > >> -- Ian > > > > No luck with boot.netif.name. > > > > I'm using the kernel that comes in the FreeBSD RPI-B disk image. Is > > there a way to see what it was built with? I tried running strings on > > the kernel, but I'm not sure what to look for. Otherwise I guess I'll > > build one myself. > > > > Randy > > > > Hi, > > The problem is that the code in: > > sys/nfs/bootp_subr.c: SYSINIT(bootp_rootconf, SI_SUB_ROOT_CONF, > SI_ORDER_FIRST, bootpc_init, NULL); > > doesn't wait for the USB ethernet device to be enumerated. Only the > vfs_mountroot() code which is running from the init-process does so. > > Not sure what the best way to solve this is. Try putting: > > pause("W", hz * 4); > > Into the beginning of the "bootpc_init()" function. > > --HPS I had time to look into this today. The bootpc_init() routine *does* wait for an interface to appear. The problem in this case is that BOOTP isn't involved, and the nfs_setup_diskless() routine doesn't have a similar wait loop for slow interfaces. The attached patch adds it, and with it I can nfsmount root on my RPi without using the BOOTP_foo options I listed above. Rick, does this patch look okay to you? If no objections, I'll commit this asap. -- Ian --=-JFrIpY5MfS0yWt+nRO0J Content-Disposition: inline; filename="nfs_diskless_iface_timeout.diff" Content-Type: text/x-patch; name="nfs_diskless_iface_timeout.diff"; charset="us-ascii" Content-Transfer-Encoding: 7bit Index: sys/nfs/nfs_diskless.c =================================================================== --- sys/nfs/nfs_diskless.c (revision 288203) +++ sys/nfs/nfs_diskless.c (working copy) @@ -57,6 +57,8 @@ __FBSDID("$FreeBSD$"); #include #include +#define IFACE_TIMEOUT_SECS 10 /* Timeout for interface to appear. */ + static int inaddr_to_sockaddr(char *ev, struct sockaddr_in *sa); static int hwaddr_to_sockaddr(char *ev, struct sockaddr_dl *sa); static int decode_nfshandle(char *ev, u_char *fh, int maxfh); @@ -170,6 +172,7 @@ nfs_setup_diskless(void) char *cp; int cnt, fhlen, is_nfsv3; uint32_t len; + time_t timeout_at; if (nfs_diskless_valid != 0) return; @@ -214,6 +217,8 @@ nfs_setup_diskless(void) return; } ifa = NULL; + timeout_at = time_uptime + IFACE_TIMEOUT_SECS; +retry: CURVNET_SET(TD_TO_VNET(curthread)); IFNET_RLOCK(); TAILQ_FOREACH(ifp, &V_ifnet, if_link) { @@ -234,6 +239,10 @@ nfs_setup_diskless(void) } IFNET_RUNLOCK(); CURVNET_RESTORE(); + if (time_uptime < timeout_at) { + pause("nfssdl", hz / 5); + goto retry; + } printf("nfs_diskless: no interface\n"); return; /* no matching interface */ match_done: --=-JFrIpY5MfS0yWt+nRO0J--