From owner-svn-src-head@FreeBSD.ORG Thu Dec 1 04:05:56 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E34571065670; Thu, 1 Dec 2011 04:05:56 +0000 (UTC) (envelope-from fjoe@samodelkin.net) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 806DE8FC12; Thu, 1 Dec 2011 04:05:56 +0000 (UTC) Received: by ywp17 with SMTP id 17so2197627ywp.13 for ; Wed, 30 Nov 2011 20:05:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.45.6 with SMTP id i6mr1114080obm.3.1322712355718; Wed, 30 Nov 2011 20:05:55 -0800 (PST) Sender: fjoe@samodelkin.net Received: by 10.182.76.225 with HTTP; Wed, 30 Nov 2011 20:05:55 -0800 (PST) X-Originating-IP: [93.92.220.178] In-Reply-To: <20111201001646.GA49249@freebsd.org> References: <201111301807.pAUI7cXI008371@svn.freebsd.org> <20111201001646.GA49249@freebsd.org> Date: Thu, 1 Dec 2011 11:05:55 +0700 X-Google-Sender-Auth: RNh7HDs5haDxkTCIzCceOgj-pV8 Message-ID: From: Max Khon To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228157 - head/usr.bin/make X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 04:05:57 -0000 Alexander, On Thu, Dec 1, 2011 at 7:16 AM, Alexander Best wrote: > Author: fjoe > > Date: Wed Nov 30 18:07:38 2011 > > New Revision: 228157 > > URL: http://svn.freebsd.org/changeset/base/228157 > > > > Log: > > - Fix segmentation fault when running "+command" when run with -jX -n > due > > to Compat_RunCommand() being called with `cmd' that is not on the > node->commands > > list > > - Make ellipsis ("..." command) handling consistent: check for "..." > command > > in job make after variables expansion to match compat make behavior > > - Fix empty command handling (after variables expansion and @+- > modifiers > > are processed): now empty commands are ignored in compat make and are > not > > printed in job make case > > - Bump MAKE_VERSION to 5-2011-11-30-0 > > it would also be nice, if at some point, somebody could dive into the code > to > see why 'make buildkernel' will let clang produce coloured output, but > 'make -j(N>1) buildkernel' doesn't (and why adding a -B switch to that > command > fixes it). > This one is simple: job make (-jX) runs commands with stdin/stdout/stderr redirected to pipes. -B turns on compat mode for job make. This can be demonstrated by running make with -jX or -jX -B with the following Makefile: --- cut here --- all: @if [ -t 1 ]; then echo "stdout is a tty"; else echo "stdout is not a tty"; fi --- cut here --- If you really want to see colored output in -jX case you should teach clang to output ANSI color sequences not only in isatty(1) case, but also when MAKE_JOBS_FIFO environment variable is present (it is set when make runs in job mode). Max