From owner-svn-src-head@freebsd.org Thu Sep 17 11:59:11 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92F579CE7BE for ; Thu, 17 Sep 2015 11:59:11 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3205817B5 for ; Thu, 17 Sep 2015 11:59:10 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wicfx3 with SMTP id fx3so20449883wic.1 for ; Thu, 17 Sep 2015 04:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=v7xRfsruzQTeXbKAvB1qPC3AHHdukJdMRAbb4doUhuQ=; b=gvO/iaezXihKu+PWwBK+qRMt6aWm/nJjnoMcKnA9ucwr3C1O14qfEv9oglBDkLtl1r G30ZONI579/irvGx0XlOvB2/RKoYb2nr2HjmtkdxN3aUC2h+NMmQGxVDNFD51RMW75gy 764Skg+3Odn5zXK+eZ4IFiC3STlZmPdIl2iLTaaNr2yVTU9vOEc7fYMs11qGccUa4lcA KvkvxRFf1UQ28tC0ZsebHqb22/UHUVYRAy0/IeY7P70AZkTeYCk8Q1LFDO8KsO9Nm9ex uZinAA+ry64yv1hUf2N6Qkkt8GvnRCYGaHUg+Z4JrAn7NUoanJ62QXkKHK/LlztL9YPJ dUIw== X-Gm-Message-State: ALoCoQliFfTxMDNy78aQf4Bgp3C0wz041PmXTszZJ8cN/Py4XP/YY9MSO0mRO4N2/8l8R+Ltn2LL X-Received: by 10.194.122.66 with SMTP id lq2mr62396379wjb.156.1442491148701; Thu, 17 Sep 2015 04:59:08 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id cx3sm3046300wjc.27.2015.09.17.04.59.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2015 04:59:07 -0700 (PDT) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r287886 - head/sys/sys To: Alexey Dokuchaev References: <201509170003.t8H03uSf070155@repo.freebsd.org> <20150917081541.GA65088@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <55FAAB03.2090409@freebsd.org> Date: Thu, 17 Sep 2015 12:58:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150917081541.GA65088@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 11:59:11 -0000 On 17/09/2015 09:15, Alexey Dokuchaev wrote: > On Thu, Sep 17, 2015 at 12:03:56AM +0000, Steven Hartland wrote: >> New Revision: 287886 >> URL: https://svnweb.freebsd.org/changeset/base/287886 >> >> Log: >> Fix kqueue write events for files > 2GB >> >> Due to the use of int's for file offsets in the VOP_WRITE_(PRE|POST) >> macros, kqueue write events for files greater 2GB where never fired. >> >> This caused tail -f on a file greater 2GB to never see updates. > Oh that's an embarrassing bug. > >> MFC after: 1 week > Would you also consider merging to stable/8? Thanks, > > ./danfe 8 isn't supported any more but the patch should apply to stable/8 sources if you maintain your own branch of it. Regards Steve