From owner-freebsd-stable@freebsd.org Sat Feb 25 15:00:36 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7CA3CEC2C8 for ; Sat, 25 Feb 2017 15:00:36 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 321DB1A1 for ; Sat, 25 Feb 2017 15:00:35 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA08059; Sat, 25 Feb 2017 17:00:34 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1chdpq-0002Pf-4d; Sat, 25 Feb 2017 17:00:34 +0200 Subject: Re: cyapa(4) and isl(4) no longer working on Acer C720 To: Wolfgang Zenker , freebsd-stable@FreeBSD.org References: <20170225131023.GA94128@lyxys.ka.sub.org> <2763492b-6c8c-08c1-17ca-13e1d94f5543@FreeBSD.org> From: Andriy Gapon Message-ID: <357d6dda-6137-7246-bd33-b7e5d8f20667@FreeBSD.org> Date: Sat, 25 Feb 2017 16:59:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2763492b-6c8c-08c1-17ca-13e1d94f5543@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Feb 2017 15:00:36 -0000 On 25/02/2017 16:46, Andriy Gapon wrote: > On 25/02/2017 15:10, Wolfgang Zenker wrote: >> Hi, >> >> I'm using FreeBSD 11 on a chromebook Acer C720. Because I normally >> use a mouse I didn't catch the exact time when cyapa and isl stopped >> working, but my guess is it was when chromebook_framework was introduced >> and cyapa and isl were moved to using iic. >> >> A manual page chromebook_platform(4) does not exist. Maybe the Acer is >> sufficiently different from other chromebooks that chromebook_platform >> does not work here. In that case I'm supposed to set device hints for >> the isl and cyapa drivers where to find their iic resources, according >> to https://github.com/freebsd/freebsd-base-graphics/commit/e2eab8e254154d36ebd6fde573f86e6472b75572 >> Unfortunately I have no idea where to find the information that would >> be needed for this. > The manual page actually exists... but only in the source code :-( > share/man/man4/chromebook_platform.4 > Mea culpa. > > You can look through this Linux source file to check for information that's > relevant to your laptop: > http://lxr.free-electrons.com/source/drivers/platform/chrome/chromeos_laptop.c In fact, could you please try this trivial patch? Index: sys/dev/chromebook_platform/chromebook_platform.c =================================================================== --- sys/dev/chromebook_platform/chromebook_platform.c (revision 314268) +++ sys/dev/chromebook_platform/chromebook_platform.c (working copy) @@ -69,7 +69,7 @@ * See http://lxr.free-electrons.com/source/drivers/platform/chrome/chromeos_laptop.c */ controller = device_get_parent(bus); - if (strcmp(device_get_name(controller), "ig4iic") != 0) + if (strcmp(device_get_name(controller), "ig4iic_pci") != 0) return; for (i = 0; i < nitems(slaves); i++) { Seems like I overlooked this when reviewing https://svnweb.freebsd.org/base?view=revision&revision=310621 -- Andriy Gapon