From owner-freebsd-dtrace@freebsd.org Sat Nov 11 02:52:22 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7842E5C651 for ; Sat, 11 Nov 2017 02:52:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg0-x22f.google.com (mail-pg0-x22f.google.com [IPv6:2607:f8b0:400e:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 99AE86F9F1 for ; Sat, 11 Nov 2017 02:52:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg0-x22f.google.com with SMTP id g6so8736714pgn.6 for ; Fri, 10 Nov 2017 18:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6P366oasgo1QZzEAHN4ZozgKKB7QKiorAagHJYdLkPo=; b=Mdar0mnPOq/uRgTon9Q2FH/gr22SduPrS/LbuYr7XjLX7RkwMqyZ8ysQBji1wX4J+m 68UXQFYiBZAbPnx+AHiAHEC1WpOE1lXio7QcBa8nPWR6uBo9MpKyZReOb+Xs+peoKiRk VRe70IK9gY797zg+cQUNF0gejN2AHov28sCvTawKOHumswbKrMfVy175h5+v//td5vJ6 e73b60d68zwH6da6QL/6OkxN4qJNQ9VbZ74dl2/9r8IHLgd05httYJaYMCN2h7P6IO9D SWPp2V5iIimq3e5FNnnk/DgJ6uMH2G+tCKFsbgJL2VN1X//AE98FYYqKl/cwEnSBgeTj gcfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6P366oasgo1QZzEAHN4ZozgKKB7QKiorAagHJYdLkPo=; b=XyIqz/1L+rBMcvmxDssvGwHktzHSwx6JChqLFngzZVlTo83C1iRpATtOVMXUW96NaA tLb5db0l8YBW009vtcrF809032ffgoT3Qj4ar9U0VK7dDdNRcsNW/mrFJzVONXt9KpRp yNM42iD835QTj6Zjco+AQUbL6BJcdUTXY/TFnqmRuY+nuDlSXbZNU6zKLyjxoy5mOICU KpzfCZ4Bs33bBhl0bIonXud81D0HeIPbukVOcK7tUgvvJl/yyk+cXbYs/IpGkLa6GO27 EjcX8ptbo4R3LjjZkRvpT1/pRy6+v1o73sRgQoljWpQhSVhKbNhrRYawqmvBSIsICQ/W Aq1A== X-Gm-Message-State: AJaThX6APtXcB+Z8V20mMNarblye+Uu90uKzJL+J1bBzrq51aejl4onA 4/WpOEHzOH8dEFGDxaVBUuw= X-Google-Smtp-Source: AGs4zMZtBs34CgM9inM4bQWhBt/fwBLrL7xnQVPvcYxE6wIFBmJWwuHTvHmXzcJKahMjJ4jYEPG65A== X-Received: by 10.99.189.18 with SMTP id a18mr2253602pgf.168.1510368741920; Fri, 10 Nov 2017 18:52:21 -0800 (PST) Received: from bish (59-125-183-239.HINET-IP.hinet.net. [59.125.183.239]) by smtp.gmail.com with ESMTPSA id r67sm16062173pfj.59.2017.11.10.18.52.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Nov 2017 18:52:20 -0800 (PST) Sender: Mark Johnston Date: Fri, 10 Nov 2017 22:52:12 -0500 From: Mark Johnston To: Andreas Longwitz Cc: "freebsd-dtrace@freebsd.org" Subject: Re: dtrace pid provider on entry == Trace/BPT trap process Message-ID: <20171111035212.GA1176@bish> References: <59AE834E.1090700@incore.de> <20170905144154.GC65864@wkstn-mjohnston.west.isilon.com> <5A0195CA.2010907@incore.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A0195CA.2010907@incore.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Nov 2017 02:52:22 -0000 On Tue, Nov 07, 2017 at 12:15:22PM +0100, Andreas Longwitz wrote: > Maybe the following is of interest for DTrace experts: > > >> I use FreeBSD 10.3-STABLE r317936 with updated /usr/lib/dtrace/ip.c and > >> see an issue that in my opinion should have been solved in r269342: > > > > 10.3 would be missing a number of other fixes for issues that might > > cause the symptom you're seeing. Unfortunately, userland DTrace is not > > very usable on FreeBSD before 11.0. > > I have repeated my looptest on a server running FreeBSD 12.0-CURRENT #0 > r324306 with GENERIC kernel. I saw the same problem as described before > for FreeBSD 10.3-Stable r317936: > > Nov 7 10:54:09 dssbkp2 kernel: pid 38041 (looptest), uid > 1003: exited on signal 5 > > Further I saw following error message from dtrace: > > dtrace: failed to grab pid 38622: Device busy. > > After some minutes playing around the server crashed with > > panic: PHOLD of exiting process 0xfffff80004c80540 Sorry for the delayed reply. I think this assertion is bogus: the process in question is already held at this point, so it can't continue exiting anyway. I think the patch below will address this and the SIGTRAP crashes. Could you give it a try? diff --git a/sys/cddl/compat/opensolaris/kern/opensolaris_proc.c b/sys/cddl/compat/opensolaris/kern/opensolaris_proc.c index 652fa8928589..63db17199fb4 100644 --- a/sys/cddl/compat/opensolaris/kern/opensolaris_proc.c +++ b/sys/cddl/compat/opensolaris/kern/opensolaris_proc.c @@ -35,9 +35,7 @@ uread(proc_t *p, void *kaddr, size_t len, uintptr_t uaddr) { ssize_t n; - PHOLD(p); n = proc_readmem(curthread, p, uaddr, kaddr, len); - PRELE(p); if (n != len) return (ENOMEM); return (0); @@ -48,9 +46,7 @@ uwrite(proc_t *p, void *kaddr, size_t len, uintptr_t uaddr) { ssize_t n; - PHOLD(p); n = proc_writemem(curthread, p, uaddr, kaddr, len); - PRELE(p); if (n != len) return (ENOMEM); return (0); diff --git a/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c b/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c index 82353cbb235d..d721270fd425 100644 --- a/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c +++ b/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c @@ -64,6 +64,7 @@ #include #include #include +#include #include #include #include @@ -1097,6 +1098,8 @@ fasttrap_tracepoint_disable(proc_t *p, fasttrap_probe_t *probe, uint_t index) p->p_dtrace_count--; } + (void)quiesce_all_cpus("fasttrap", 0); + /* * Remove the probe from the hash table of active tracepoints. */ diff --git a/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c b/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c index d6655a0b3c55..0364aaf55094 100644 --- a/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c +++ b/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c @@ -1715,11 +1715,7 @@ fasttrap_pid_probe(struct reg *rp) ASSERT(i <= sizeof (scratch)); -#ifdef illumos if (fasttrap_copyout(scratch, (char *)addr, i)) { -#else - if (uwrite(p, scratch, i, addr)) { -#endif fasttrap_sigtrap(p, curthread, pc); new_pc = pc; break;