From owner-freebsd-bugs@FreeBSD.ORG Fri Dec 15 01:00:32 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 993E716A412 for ; Fri, 15 Dec 2006 01:00:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63EB943CD5 for ; Fri, 15 Dec 2006 00:58:47 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kBF10PWF052026 for ; Fri, 15 Dec 2006 01:00:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kBF10PZi052025; Fri, 15 Dec 2006 01:00:25 GMT (envelope-from gnats) Date: Fri, 15 Dec 2006 01:00:25 GMT Message-Id: <200612150100.kBF10PZi052025@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Tom Rhodes Cc: Subject: Re: kern/106703: [PATCH] vn_stat() fails with files > 2Gb on msdosfs (non 386) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tom Rhodes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2006 01:00:32 -0000 The following reply was made to PR kern/106703; it has been noted by GNATS. From: Tom Rhodes To: Remko Lodder Cc: loox@e-shell.net, freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/106703: [PATCH] vn_stat() fails with files > 2Gb on msdosfs (non 386) Date: Thu, 14 Dec 2006 19:48:48 -0500 On Thu, 14 Dec 2006 08:06:53 +0100 Remko Lodder wrote: > On Thu, Dec 14, 2006 at 06:30:15AM +0000, Axel Gonzalez wrote: > > > > >Description: > > When you copy/create a file > 2Gb on a msdosfs, it is created correctly, but vn_stat() fails on the file. > > > > Since the function is used on several userland programs (ls, rm), it seems like the file is not on the FS. > > > > Hello, > > first of all thanks for the report to help make FreeBSD better! > > One thing that crosses my mind is that (in my believing) the maximum > size of a file under msdos(fs) was 2gb, which could explain this > "problem" you are seeing. If that is still accurate, I don't think > we should patch the file you mention, but refuse to accept files > larger then 2gb since they will then not be visible at all on the > disk when msdos itself is being used (or some other OS that reads > out the msdosfs). > > I copied in Tom Rhodes for more clarification (he maintains msdosfs). > > Again thanks for the report and taking the time to mention this! > > Cheers, > remko Hmm, that is an interesting problem, and I'm digging the fix. FAT32 should handle file sizes up to (2^32)-1 bytes (one byte fewer than four gigabytes. So we should properly handle this for all FAT32 file systems. Heh, I don't want maintainership of MSDOSFS, can I give it back or sell it to someone? It's rarely used, I've only touched it a few times. :P -- Tom Rhodes