From owner-svn-src-all@FreeBSD.ORG Thu Aug 2 14:37:17 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B9DD106566B; Thu, 2 Aug 2012 14:37:17 +0000 (UTC) (envelope-from listlog2011@gmail.com) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 23FAF8FC0C; Thu, 2 Aug 2012 14:37:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q72Eb2QB063036; Thu, 2 Aug 2012 14:37:06 GMT (envelope-from listlog2011@gmail.com) Message-ID: <501A908B.9010001@gmail.com> Date: Thu, 02 Aug 2012 22:36:59 +0800 From: David Xu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Bruce Evans References: <201207310548.q6V5mZHf091624@svn.freebsd.org> <50179581.9070805@gmail.com> <20120802051805.P3345@besplex.bde.org> <5019ED93.8060802@gmail.com> <20120802173441.X1291@besplex.bde.org> <501A72AE.30309@gmail.com> <20120803001044.X2863@besplex.bde.org> In-Reply-To: <20120803001044.X2863@besplex.bde.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, Giovanni Trematerra , svn-src-all@freebsd.org, Konstantin Belousov , davidxu@freebsd.org, svn-src-head@freebsd.org, bde@freebsd.org Subject: Re: svn commit: r238936 - in head/sys: fs/fifofs kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: davidxu@freebsd.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2012 14:37:17 -0000 On 2012/8/2 22:17, Bruce Evans wrote: > On Thu, 2 Aug 2012, David Xu wrote: > >> On 2012/8/2 16:12, Bruce Evans wrote: >>> ... >>> I made similar patches for sockets (to set POLLHUP on hangup (now in >>> -current) and to not set POLLIN on hangup unless there is still data >>> to be read). I started killing POLLINIGNEOF for sockets. -current >>> added it for nameless pipes instead :-(. With the new fifo >>> implementation, POLLINIGNEOF is even more of a mistake for sockets, >>> but more needed for pipes since named pipes are fifos. >>> ... >> I think you can kill POLLINIGNEOF at all, I have grepped, and there >> is no external user, >> only pipe and socket code use it internally. The POLLINIGNEOF is >> confusing because >> it has same prefix with POLLIN, POLLOUT and other POLL flags. > > Did you grep all of google for it :-). All of ports should be enough. > > Uses of it in the kernel are certainly gone, but it was intentionally > put in the user API to previde a workaround for the policy that was > hard-coded in the kernel. The policy changed slightly, and you could > set POLLINIGNEOF to either go back to the old policy or get the new > policy for more cases. Hopefully this was never actually used except > for testing and termporary workarounds. But it was expanded to work > on nameless pipes as well as fifos and sockets. > > Bruce > I don't know it is used by some ports. :-) Anyway, if people don't agree my patches, it is not a problem to me, because I always can apply them locally, though named pipe may be less useful from offical release. Thanks,