Date: Sat, 4 Feb 2006 00:28:41 +0100 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: Robert N M Watson <rwatson@freebsd.org> Subject: Re: [head tinderbox] failure on amd64/amd64 Message-ID: <200602040028.47826.max@love2party.net> In-Reply-To: <20060203230755.B8CA57302F@freebsd-current.sentex.ca> References: <20060203230755.B8CA57302F@freebsd-current.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1286987.uLmHBk7in1 Content-Type: multipart/mixed; boundary="Boundary-01=_rc+4Do6Z1GZsyoy" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_rc+4Do6Z1GZsyoy Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 04 February 2006 00:07, FreeBSD Tinderbox wrote: > -finstrument-functions -Wno-inline /src/sys/security/audit/audit_arg.c > /src/sys/security/audit/audit_arg.c: In function `audit_arg_upath': > /src/sys/security/audit/audit_arg.c:676: warning: long long unsigned int > format, u_int64_t arg (arg 2) /src/sys/security/audit/audit_arg.c:678: > warning: long long unsigned int format, u_int64_t arg (arg 2) *** Error > code 1 Once again, fixed by - for example - the attached patch. Alternatively: .. "%ju", (uintmax_t)arg .. // we are so C99 I take this a chance to rant if we could remove this stupid 64bit=20 unportability. It should be possible to have a CASSERT somewhere that shut= s=20 this up if "sizeof(u_int64_t) =3D=3D sizeof(unsigned long long)" or the lik= e. I=20 hope somebody has more insight and how/where to fix it properly. Otherwise= =20 we will run into this portability issue over and over again. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-01=_rc+4Do6Z1GZsyoy Content-Type: text/x-diff; charset="iso-8859-6"; name="longlongahrg.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="longlongahrg.diff" Index: audit_arg.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/store/mlaier/fcvs/src/sys/security/audit/audit_arg.c,v retrieving revision 1.1 diff -u -r1.1 audit_arg.c =2D-- audit_arg.c 1 Feb 2006 20:01:18 -0000 1.1 +++ audit_arg.c 3 Feb 2006 23:19:26 -0000 @@ -674,9 +674,9 @@ * XXXAUDIT: Witness warning for possible sleep here? */ KASSERT((flag =3D=3D ARG_UPATH1) || (flag =3D=3D ARG_UPATH2), =2D ("audit_arg_upath: flag %llu", flag)); + ("audit_arg_upath: flag %llu", (unsigned long long)flag)); KASSERT((flag !=3D ARG_UPATH1) || (flag !=3D ARG_UPATH2), =2D ("audit_arg_upath: flag %llu", flag)); + ("audit_arg_upath: flag %llu", (unsigned long long)flag)); =20 ar =3D currecord(); if (ar =3D=3D NULL) --Boundary-01=_rc+4Do6Z1GZsyoy-- --nextPart1286987.uLmHBk7in1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD4+cvXyyEoT62BG0RArbgAJ93TBqmmhr2a/QXUAcoVd2jgYXShQCbBv0X jcIpDstGefIQ2JGPGPbhY6U= =O6G0 -----END PGP SIGNATURE----- --nextPart1286987.uLmHBk7in1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602040028.47826.max>