From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 8 07:20:20 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A424616A4CE for ; Tue, 8 Jun 2004 07:20:20 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98F3243D31 for ; Tue, 8 Jun 2004 07:20:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i587KKnX069832 for ; Tue, 8 Jun 2004 07:20:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i587KK7C069831; Tue, 8 Jun 2004 07:20:20 GMT (envelope-from gnats) Resent-Date: Tue, 8 Jun 2004 07:20:20 GMT Resent-Message-Id: <200406080720.i587KK7C069831@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Linimon Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EC7716A4CE; Tue, 8 Jun 2004 07:19:43 +0000 (GMT) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53D8E43D1F; Tue, 8 Jun 2004 07:19:43 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: from lonesome.lonesome.com (cs242743-143.austin.rr.com [24.27.43.143]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mail.soaustin.net (Postfix) with ESMTP id BE09814311; Tue, 8 Jun 2004 02:19:42 -0500 (CDT) Received: from lonesome.lonesome.com (localhost.lonesome.com [127.0.0.1]) by lonesome.lonesome.com (8.12.9/8.12.9) with ESMTP id i587HhSQ019823; Tue, 8 Jun 2004 02:17:43 -0500 (CDT) (envelope-from linimon@lonesome.lonesome.com) Received: (from linimon@localhost) by lonesome.lonesome.com (8.12.9/8.12.9/Submit) id i587Hhch019822; Tue, 8 Jun 2004 02:17:43 -0500 (CDT) (envelope-from linimon) Message-Id: <200406080717.i587Hhch019822@lonesome.lonesome.com> Date: Tue, 8 Jun 2004 02:17:43 -0500 (CDT) From: Mark Linimon To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: portmgr@FreeBSD.org Subject: ports/67705: [patch] change handling of unsuitable MySQL versions from BROKEN to IGNORE X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Mark Linimon List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 07:20:20 -0000 >Number: 67705 >Category: ports >Synopsis: [patch] change handling of unsuitable MySQL versions from BROKEN to IGNORE >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jun 08 07:20:20 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Mark Linimon >Release: FreeBSD 4.9-PRERELEASE i386 >Organization: Lonesome Dove Computing Services >Environment: System: FreeBSD lonesome.lonesome.com 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #3: Thu Jan 22 20:41:05 CST 2004 root@lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA i386 >Description: There are a number of ports that only work with certain versions of MySQL. There are Makevars in bsd.port.mk that a port's Makefile can set to indicate this. However, the logic in bsd.port.mk sets the (internal) BROKEN Makevar -- not IGNORE -- and thus bento attempts to build the port with the default MySQL, although this build can never succeed. The second-order effect is that portsmon will include these ports in the periodic email to maintainers reminding them about their broken ports, and this email is actually spurious. >How-To-Repeat: cd databases/mysqlcc (or databases/mysql-administrator); make -V BROKEN >Fix: The following patch to bsd.port.mk fixes the problem. I will leave it up to portmgr discretion about whether the Makevar itself should be renamed. Index: bsd.port.mk =================================================================== RCS file: /home/FreeBSD/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.490 diff -u -r1.490 bsd.port.mk --- bsd.port.mk 31 May 2004 18:07:57 -0000 1.490 +++ bsd.port.mk 8 Jun 2004 07:04:40 -0000 @@ -1492,7 +1502,7 @@ .if defined(BROKEN_WITH_MYSQL) . for VER in ${BROKEN_WITH_MYSQL} . if (${MYSQL_VER} == "${VER}") -BROKEN= "Doesn't work with MySQL version : ${MYSQL_VER} (Doesn't support MySQL ${BROKEN_WITH_MYSQL})" +IGNORE= "Doesn't work with MySQL version : ${MYSQL_VER} (Doesn't support MySQL ${BROKEN_WITH_MYSQL})" . endif . endfor .endif # BROKEN_WITH_MYSQL >Release-Note: >Audit-Trail: >Unformatted: