From owner-svn-src-all@FreeBSD.ORG Wed Jul 3 09:23:10 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
by hub.freebsd.org (Postfix) with ESMTP id 78DCFB38;
Wed, 3 Jul 2013 09:23:10 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net
[IPv6:2a01:4f8:131:23c2::1])
by mx1.freebsd.org (Postfix) with ESMTP id 16A9B1843;
Wed, 3 Jul 2013 09:23:09 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
by acme.spoerlein.net (8.14.7/8.14.7) with ESMTP id r639N7TS070189
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
Wed, 3 Jul 2013 11:23:08 +0200 (CEST) (envelope-from uqs@FreeBSD.org)
Date: Wed, 3 Jul 2013 11:23:07 +0200
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: Hiroki Sato <hrs@FreeBSD.org>
Subject: Re: svn commit: r252408 - head/sbin/ifconfig
Message-ID: <20130703092307.GA2294@acme.spoerlein.net>
Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>,
Hiroki Sato <hrs@FreeBSD.org>, src-committers@freebsd.org,
svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201306300737.r5U7bWkB096070@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201306300737.r5U7bWkB096070@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for "
user" and " projects" \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jul 2013 09:23:10 -0000
On Sun, 2013-06-30 at 07:37:32 +0000, Hiroki Sato wrote:
> Author: hrs
> Date: Sun Jun 30 07:37:31 2013
> New Revision: 252408
> URL: http://svnweb.freebsd.org/changeset/base/252408
>
> Log:
> Do not display a warning message in a jail without AF_INET6 support.
>
> MFC after: 3 days
>
> Modified:
> head/sbin/ifconfig/af_nd6.c
>
> Modified: head/sbin/ifconfig/af_nd6.c
> ==============================================================================
> --- head/sbin/ifconfig/af_nd6.c Sun Jun 30 06:44:31 2013 (r252407)
> +++ head/sbin/ifconfig/af_nd6.c Sun Jun 30 07:37:31 2013 (r252408)
> @@ -148,7 +148,7 @@ nd6_status(int s)
> memset(&nd, 0, sizeof(nd));
> strncpy(nd.ifname, ifr.ifr_name, sizeof(nd.ifname));
> if ((s6 = socket(AF_INET6, SOCK_DGRAM, 0)) < 0) {
> - if (errno != EAFNOSUPPORT)
> + if (errno != EAFNOSUPPORT && error != EPROTONOSUPPORT)
> warn("socket(AF_INET6, SOCK_DGRAM)");
> return;
> }
This gives undefined behavior, error is uninitialized at this point.
Found by: Coverity Scan, CID 1042128
Cheers,
Uli