From owner-svn-src-all@freebsd.org Thu Mar 31 08:18:53 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5567EAE3EEA for ; Thu, 31 Mar 2016 08:18:53 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF2371BBD for ; Thu, 31 Mar 2016 08:18:52 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lf0-x22c.google.com with SMTP id p188so26741022lfd.0 for ; Thu, 31 Mar 2016 01:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9eLfngmNh181yFN33QfzOHX9SXj6u6pTIGZTuOxTCmw=; b=2JUo3RSrt34WhDLqVejqxENwFZNKUPK+j5PoGs4sveoVf3KBEumRtRJF5b3P6QDUIY bJ7X/JearHadY9j5kdRUTI/LCDUdOUA+LJKWty7eOxYNfjmmSLQPOiOcXz0uVJv1W9lh fYxWCudG+BtmkRovq4qEQoWY4/sGc3cULV3ylYUTguSpRJL2crGtTnxhq/ejezw0Uw4k YNakUXmCksXLPmCE/c2WZ+xOxRpREAzs3XrhDtoGSIgMjMp1V/4BqrOOC9oaRM78Q7wV oAHfC9C5dyCqnna/xhRlG7rqPvLE4W/Uk4dQ0xFeLZn9MHeuE0Ov517csOVjxqfpmz73 fAjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9eLfngmNh181yFN33QfzOHX9SXj6u6pTIGZTuOxTCmw=; b=GFlhM8+D0vjPB5EqPIqyR2u5G8rR+VVlVoTIEX6BZeG72OS7e+Kz18Q6dF5J8G6AQ/ NcL1BxeJOgOdPaFKhlYvCsWvAY83Ac9BFBXd9/lPE+NYcbyvkeRReBT2NiLGEi+eEeu9 UPU4VcM0qrEdEpDrL4/Po7ORnCAV1FsDEFX31c9/noFmSCVz9N9XyBnKPd04k8AGpREK gRRegrL2JoTt2KEQI0TNHFup2nl03tEg9/dtsRdMIdUHnfxhlsM6XJcKgboTQg7lEeWl wNQHSKx1KU7zfKPLzM5I6iE8TQwhG0pFXIG/07dhACsa0a06lF0YrQDkIoX0mA0GLUsm Rtew== X-Gm-Message-State: AD7BkJJjiWSGVhEyxVI+W7ySzSFIHHDGMgw1rexdPwE8RVHC/T+44z2wNhGwzi6rnCGi4t7DyVbv2njlEdXcdA== X-Received: by 10.25.41.140 with SMTP id p134mr6245253lfp.15.1459412330941; Thu, 31 Mar 2016 01:18:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.77.202 with HTTP; Thu, 31 Mar 2016 01:18:31 -0700 (PDT) In-Reply-To: <56FC0B55.1040805@freebsd.org> References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <56FBE3D6.9050205@freebsd.org> <56FC0B55.1040805@freebsd.org> From: Zbigniew Bodek Date: Thu, 31 Mar 2016 10:18:31 +0200 Message-ID: Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Nathan Whitehorn Cc: Ed Maste , Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 08:18:53 -0000 Are you sure? I don't see an example of what you are writing about. Instead I can see several other examples such as: dev/usb/controller/ehci_fsl.c optional ehci mpc85xx | ehci qoriq_dpaa dev/iicbus/adm1030.c optional powermac windtunnel | adm1030 powermac etc. Why would they do that if they could simply type: ehci mpc85xx | qoriq_dpaa? Best regards zbb 2016-03-30 19:22 GMT+02:00 Nathan Whitehorn : > I think it should be pci aim | fdt, just like the previous line when the > files lived in sys/powerpc. To conf, that evaluates as pci && (aim || fdt). > -Nathan > > > On 03/30/16 08:55, Zbigniew Bodek wrote: > > > Thank you Nathan. Please check out new patch in the attachment. > > Best regards > zbb > > 2016-03-30 16:33 GMT+02:00 Nathan Whitehorn : > >> PowerPC (and SPARC) can have real OFW without FDT support. Adding FDT to >> LINT is the wrong solution: rather, it should switch on fdt | aim like the >> rest of the Open Firmware code. >> -Nathan >> >> >> On 03/30/16 01:54, Zbigniew Bodek wrote: >> >> Hello Ed, >> >> Please check out the attached patch. For powerpc we should compile-in >> ofwpci.c regardless of FDT option. >> However, it seems that LINT for powerpc does not have FDT. What do you >> thing about adding it (as can be seen in the attached patch)?. This would >> be done in a separate commit. >> >> Best regards >> zbb >> >> 2016-03-30 1:53 GMT+02:00 Ed Maste < >> emaste@freebsd.org>: >> >>> On 29 March 2016 at 15:19, Zbigniew Bodek < >>> zbb@freebsd.org> wrote: >>> > Author: zbb >>> > Date: Tue Mar 29 15:19:56 2016 >>> > New Revision: 297392 >>> > URL: https://svnweb.freebsd.org/changeset/base/297392 >>> > >>> > Log: >>> > Reduce OFW PCI code duplication - involves ARM, PPC and SPARC64 >>> >>> My 'make tinderbox' build is now failing (powerpc LINT) with: >>> >>> linking kernel >>> cpcht.o: In function `cpcht_attach': >>> cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' >>> cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >>> grackle.o: In function `grackle_attach': >>> grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' >>> grackle.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >>> uninorthpci.o: In function `uninorth_attach': >>> uninorthpci.c:(.text+0x68c): undefined reference to `ofw_pci_attach' >>> uninorthpci.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >>> *** [kernel] Error code 1 >>> _______________________________________________ >>> svn-src-all@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>> To unsubscribe, send any mail to " >>> svn-src-all-unsubscribe@freebsd.org" >>> >> >> >> > >