From owner-cvs-all@FreeBSD.ORG  Tue May 11 16:06:56 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 965A416A4CF
	for <cvs-all@FreeBSD.org>; Tue, 11 May 2004 16:06:56 -0700 (PDT)
Received: from duchess.speedfactory.net (duchess.speedfactory.net
	[66.23.201.84])	by mx1.FreeBSD.org (Postfix) with SMTP id 94C8143D5A
	for <cvs-all@FreeBSD.org>; Tue, 11 May 2004 16:06:55 -0700 (PDT)
	(envelope-from ups@tree.com)
Received: (qmail 21821 invoked by uid 89); 11 May 2004 23:06:53 -0000
Received: from duchess.speedfactory.net (66.23.201.84)
  by duchess.speedfactory.net with SMTP; 11 May 2004 23:06:53 -0000
Received: (qmail 21792 invoked by uid 89); 11 May 2004 23:06:53 -0000
Received: from unknown (HELO palm.tree.com) (66.23.216.49)
  by duchess.speedfactory.net with SMTP; 11 May 2004 23:06:53 -0000
Received: from palm.tree.com (localhost.tree.com [127.0.0.1])
	by palm.tree.com (8.12.10/8.12.10) with ESMTP id i4BN6q9F030876;
	Tue, 11 May 2004 19:06:52 -0400 (EDT)
	(envelope-from ups@palm.tree.com)
Message-Id: <200405112306.i4BN6q9F030876@palm.tree.com>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Andre Oppermann <andre@FreeBSD.org>
In-Reply-To: Message from Andre Oppermann <andre@FreeBSD.org> 
	<200404231610.i3NGAOYF092229@repoman.freebsd.org> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 11 May 2004 19:06:52 -0400
From: Stephan Uphoff <ups@tree.com>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_gre.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 May 2004 23:06:56 -0000


>   FreeBSD src repository
> 
>   Modified files:
>     sys/net              if_gre.c 
>   Log:
>   Call ip_output() with IP_FORWARD flag to prevent it from overwriting the
>   ip_id again.  ip_id is already set to the ip_id of the encapsulated packet.
>   
>   Make a comment about mbuf allocation failures more realistic.
>   
>   Reviewed by:    sobomax
>   
>   Revision  Changes    Path
>   1.22      +2 -2      src/sys/net/if_gre.c


Is this the right thing to do for forwarded (non locally generated) packets ?
Mixing id sequences from different providers can't be healthy.

	Stephan