From owner-freebsd-scsi@FreeBSD.ORG Mon Aug 8 15:22:10 2011 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F08E0106566B for ; Mon, 8 Aug 2011 15:22:10 +0000 (UTC) (envelope-from chuck@tuffli.net) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id BAD3E8FC17 for ; Mon, 8 Aug 2011 15:22:10 +0000 (UTC) Received: by qwc9 with SMTP id 9so1123844qwc.13 for ; Mon, 08 Aug 2011 08:22:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.249.208 with SMTP id ml16mr4289126qcb.163.1312815152445; Mon, 08 Aug 2011 07:52:32 -0700 (PDT) Received: by 10.229.156.207 with HTTP; Mon, 8 Aug 2011 07:52:32 -0700 (PDT) In-Reply-To: <4E3F0332.7030004@feral.com> References: <4E3F0332.7030004@feral.com> Date: Mon, 8 Aug 2011 07:52:32 -0700 Message-ID: From: Chuck Tuffli To: Matthew Jacob Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-scsi@freebsd.org Subject: Re: some changes to xpt to help make unloading sim modules safer X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2011 15:22:11 -0000 On Sun, Aug 7, 2011 at 2:27 PM, Matthew Jacob wrote: > > See http://people.freebsd.org/~mjacob/xpt_patches.txt Matt - Thanks for doing this. So it seems the rule is to hold xsoftc.xpt_topo_lock while modifying bus->refcount . If so, does xpt_alloc_target need mtx_lock() / mtx_unlock() around bus->refcount++ ? ---chuck