From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 20 16:04:17 2006 Return-Path: X-Original-To: freebsd-bugs@FreeBSD.org Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F137516A415 for ; Wed, 20 Sep 2006 16:04:17 +0000 (UTC) (envelope-from keiji@hiemalis.org) Received: from parsley.hiemalis.org (parsley.hiemalis.org [219.67.146.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F0E043D62 for ; Wed, 20 Sep 2006 16:03:59 +0000 (GMT) (envelope-from keiji@hiemalis.org) Received: (qmail 96361 invoked by uid 9997); 20 Sep 2006 16:03:58 -0000 Received: from ::1 by parsley (envelope-from , uid 9997) with qmail-scanner-1.25 (clamdscan: 0.88.4/1896. sophie: 3.04/2.37/4.09. spamassassin: 3.0.4. Clear:RC:1(::1):. Processed in 0.12195 secs); 20 Sep 2006 16:03:58 -0000 Received: from localhost.hiemalis.org (HELO poker.hiemalis.org) (::1) by localhost.hiemalis.org with SMTP; 20 Sep 2006 16:03:58 -0000 Date: Thu, 21 Sep 2006 01:03:58 +0900 (JST) Message-Id: <20060921.010358.39312857.keiji@hiemalis.org> To: imp@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org From: Wada Keiji In-Reply-To: <200508301820.j7UIK0ee075010@freefall.freebsd.org> References: <200508301807.j7UI70gH021119@www.freebsd.org> <200508301820.j7UIK0ee075010@freefall.freebsd.org> X-Pgp-Fingerprint: A1 51 84 CC 76 61 EF 8D 31 0B D4 E6 AF 6A EF 9D X-Url: http://www.hiemalis.org/~keiji/ X-ICQ-UIN: 36787685 X-Mailer: xcite1.42> Mew version 5.1.50 on Emacs 22.0.50 / Mule 5.0 =?iso-2022-jp?B?KBskQjgtTFobKEIp?= Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: keiji@hiemalis.org Subject: Re: kern/85493: OLDCARD can't probe ed driver X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2006 16:04:18 -0000 Hello imp! Why don't you accept my change request? Did you read sys/dev/pccard/card_if.m # Compatibility methods for OLDCARD drivers. We use these routines to make # it possible to call the OLDCARD driver's probe routine in the context that # it expects. For OLDCARD these are implemented as pass throughs to the # device_{probe,attach} routines. For NEWCARD they are implemented such # such that probe becomes strictly a matching routine and attach does both # the old probe and old attach. # # compat devices should use the following: # # /* Device interface */ # DEVMETHOD(device_probe), pccard_compat_probe), # DEVMETHOD(device_attach), pccard_compat_attach), # /* Card interface */ # DEVMETHOD(card_compat_match, foo_match), /* newly written */ # DEVMETHOD(card_compat_probe, foo_probe), /* old probe */ # DEVMETHOD(card_compat_attach, foo_attach), /* old attach */ I think that card_compat_probe is used on OLDCARD. And on ed ed_pccard_probe is used too. So ed_pccard_probe can't use pccard_product_lookup function. What do you think? Thanks. >>>>> On Tue, 30 Aug 2005 18:20:00 GMT >>>>> FreeBSD-gnats-submit@FreeBSD.org said: > > Thank you very much for your problem report. > It has the internal identification `kern/85493'. > The individual assigned to look at your > report is: freebsd-bugs. > > You can access the state of your problem report at any time > via this link: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=85493 > > >Category: kern > >Responsible: freebsd-bugs > >Synopsis: OLDCARD can't probe ed driver > >Arrival-Date: Tue Aug 30 18:20:00 GMT 2005