From owner-svn-src-head@FreeBSD.ORG Mon Mar 30 22:19:43 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D22EE1EC for ; Mon, 30 Mar 2015 22:19:43 +0000 (UTC) Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com [IPv6:2607:f8b0:400e:c03::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E802FBD for ; Mon, 30 Mar 2015 22:19:43 +0000 (UTC) Received: by pactp5 with SMTP id tp5so13402118pac.1 for ; Mon, 30 Mar 2015 15:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=UPK7+WDzTrDOo4HLTQzkt+1IVh7C1c7u3GbWa+EQZBw=; b=nk8oaskr9+EHenPhpMlXW0IE5bIfGet896lVEI5OdBkG6mB47AvL6aFqMum9xh6Q6a S2d+ATQeGPmFKUjmMqLLeibK4du7nbrQx32hWkICwUwEI7GIZUwJKTLc1tPZ+GaKvNHN xhvZuTjKhiKmtyZIQI5i89FIKXOkpM/4bNATM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=UPK7+WDzTrDOo4HLTQzkt+1IVh7C1c7u3GbWa+EQZBw=; b=TwCyHoF/ZFpBXU3PB3Mhao543d52Bc9sHfWF+XPMYWje1Z4sN7qJt9ELfVzKn/0dDv lg7knhdFIBj6G8edc4z9U9opqCpMXTZ7e5H624TmO2j9VLTpQQPAfWg7boYfjd8REsp7 pxtRNuVM/B0L8Aixi804vuBPjfi3XzEGJhNzkLOy/1V5jBDdIw7BDVQYupeYFYM0dKNK 0oQ8eSlf4hrd0T/SedQ/72gYINGhxGHRh/Mt7MvpP6/TLkcJRaCmlDD8SAIv4yQXrlqW b0i1ibe1QssPaMzsHA1KLPrrFrKdsAfrS753u0wa2iBn+ftxJWpFh3XMCk9LeJwk3/mi wo6g== X-Gm-Message-State: ALoCoQnZR9yH7/NzbK2Jqemb3YLkIjHGA2+0goVFiAgJsTwqqb1YO/ujmW7Uys0Y9x/xg4TY2llM X-Received: by 10.70.130.132 with SMTP id oe4mr32168914pdb.153.1427753983140; Mon, 30 Mar 2015 15:19:43 -0700 (PDT) Received: from lgml-rrs.corp.netflix.com ([69.53.237.72]) by mx.google.com with ESMTPSA id wt1sm11700130pbc.76.2015.03.30.15.19.41 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 30 Mar 2015 15:19:42 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys From: Randall Stewart In-Reply-To: Date: Mon, 30 Mar 2015 16:19:41 -0600 Message-Id: <10B55CA1-47E5-43FE-9DC1-AEE4A964A65C@netflix.com> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <4E7E0A0A-5125-4F3A-AC0C-D428A972C954@netflix.com> To: Davide Italiano X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 22:19:43 -0000 Davide: I have had a long chat this weekend with imp, and both he and I feel the = right fix is to *not* bump the version, but instead change the two fields to = shorts. That way the length will still say the same so we can MFC this. I will be committing that shortly, I have it testing inside right now=85 = :-) R On Mar 28, 2015, at 2:48 PM, Davide Italiano wrote: > On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart = wrote: >> Hmm does the KPI include the size of the callout structure (which is >> private)? >>=20 >=20 > It's KBI, not KPI. >=20 >> If so I suppose we could change the c_flags/c_iflags to >> ushort =85 >>=20 >=20 > I'm not familiar with your changes enough to suggest/propose a fix. > As I previously mentioned, this looks suspicious KBI-wise to me, and I > reported to you. >=20 > --=20 > Davide >=20 > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare -------- Randall Stewart rrs@netflix.com 803-317-4952